[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5870: [sqllogictest] Run tests on Windows

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #5870:
URL: https://github.com/apache/arrow-datafusion/pull/5870#discussion_r1157766756


##########
datafusion/core/tests/sqllogictests/src/main.rs:
##########
@@ -33,16 +35,31 @@ mod utils;
 const TEST_DIRECTORY: &str = "tests/sqllogictests/test_files/";
 const PG_COMPAT_FILE_PREFIX: &str = "pg_compat_";
 
-#[tokio::main]
 #[cfg(target_family = "windows")]
-pub async fn main() -> Result<(), Box<dyn Error>> {
-    println!("Skipping test on windows");
-    Ok(())
+pub fn main() {
+    // Tests from `tpch.slt` fail with stackoverflow with the default stack size.
+    thread::Builder::new()

Review Comment:
   We have hit this before (e.g. https://github.com/apache/arrow-datafusion/issues/4065)  -- I think cranking up the default size is fine.
   
   Specifically, release builds seem to use much less stack so this is primarily a test issue rather than a production issue



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org