[jira] [Comment Edited] (LUCENE-5388) Eliminate construction over readers for Tokenizer

["Benson Margulies (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13865385#comment-13865385 ] 

Benson Margulies edited comment on LUCENE-5388 at 1/8/14 12:59 PM:
-------------------------------------------------------------------

Uwe, what's that mean practically? No PR yet? A PR just in trunk? Merging my recent doc to a 4.x branch? A feature branch where this goes to be merged in when the time is ripe?


was (Author: bmargulies):
Uwe, what's that mean practically? No PR yet? A PR just in trunk? Merging my recent doc to a 4.x branch?

> Eliminate construction over readers for Tokenizer
> -------------------------------------------------
>
>                 Key: LUCENE-5388
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5388
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/other
>            Reporter: Benson Margulies
>
> In the modern world, Tokenizers are intended to be reusable, with input supplied via #setReader. The constructors that take Reader are a vestige. Worse yet, they invite people to make mistakes in handling the reader that tangle them up with the state machine in Tokenizer. The sensible thing is to eliminate these ctors, and force setReader usage.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org