You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-dev@hadoop.apache.org by "Doroszlai, Attila (JIRA)" <ji...@apache.org> on 2019/08/06 09:55:00 UTC

[jira] [Created] (HDDS-1918) hadoop-ozone-tools has integration tests run as unit

Doroszlai, Attila created HDDS-1918:
---------------------------------------

             Summary: hadoop-ozone-tools has integration tests run as unit
                 Key: HDDS-1918
                 URL: https://issues.apache.org/jira/browse/HDDS-1918
             Project: Hadoop Distributed Data Store
          Issue Type: Improvement
          Components: build, test
    Affects Versions: 0.4.1
            Reporter: Doroszlai, Attila
            Assignee: Doroszlai, Attila


HDDS-1735 created separate test runner scripts for unit and integration tests.

Problem: {{hadoop-ozone-tools}} tests are currently run as part of the unit tests, but most of them start a {{MiniOzoneCluster}}, which is defined in {{hadoop-ozone-integration-test}}.  Thus I think these tests are really integration tests, and should be run by {{integration.sh}} instead.  There are currently only 3 real unit tests:

{noformat}
hadoop-ozone/tools/src/test/java/org/apache/hadoop/ozone/audit/parser/TestAuditParser.java
hadoop-ozone/tools/src/test/java/org/apache/hadoop/ozone/freon/TestProgressBar.java
hadoop-ozone/tools/src/test/java/org/apache/hadoop/ozone/genconf/TestGenerateOzoneRequiredConfigurations.java
{noformat}

{{hadoop-ozone-tools}} tests take ~6 minutes.

Possible solutions in order of increasing complexity:

# Run {{hadoop-ozone-tools}} tests in {{integration.sh}} instead of {{unit.sh}} (This is similar to {{hadoop-ozone-filesystem}}, which is already run by {{integration.sh}} and has 2 real unit tests.)
# Move all integration test classes to the {{hadoop-ozone-integration-test}} module, and make it depend on {{hadoop-ozone-tools}} and {{hadoop-ozone-filesystem}} instead of the other way around.
# Rename integration test classes to {{\*IT.java}} or {{IT\*.java}}, add filters for Surefire runs.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org