[GitHub] [nuttx-apps] ThePassionate commented on a diff in pull request #1998: mbedtls: update Kconfig and mbedtls_config.h

["ThePassionate (via GitHub)" <gi...@apache.org>]

ThePassionate commented on code in PR #1998:
URL: https://github.com/apache/nuttx-apps/pull/1998#discussion_r1306428018


##########
crypto/mbedtls/Kconfig:
##########
@@ -6,6 +6,7 @@
 menuconfig CRYPTO_MBEDTLS
 	bool "Mbed TLS Cryptography Library"
 	default n
+	select DEV_URANDOM

Review Comment:
   I agree with your point of view， using the system's `getrandom` is better than obtaining it from `urandom`



##########
crypto/mbedtls/Kconfig:
##########
@@ -6,6 +6,7 @@
 menuconfig CRYPTO_MBEDTLS
 	bool "Mbed TLS Cryptography Library"
 	default n
+	select DEV_URANDOM

Review Comment:
   I agree with your point of view， using the system's `getrandom` is better than obtaining it from `urandom`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org