[GitHub] [superset] mistercrunch commented on a diff in pull request #24377: chore: bump eslint-related libs

["mistercrunch (via GitHub)" <gi...@apache.org>]

mistercrunch commented on code in PR #24377:
URL: https://github.com/apache/superset/pull/24377#discussion_r1230274145


##########
superset-frontend/cypress-base/cypress/utils/index.ts:
##########
@@ -18,6 +18,8 @@
  */
 import { getChartAlias, Slice } from 'cypress/utils/vizPlugins';
 
+/* eslint-disable cypress/unsafe-to-chain-command */

Review Comment:
   idk the merit of that particular rule and it gave me quite a bit of trouble since I couldn't disable it globally for reasons beyond my understanding. 
   
   Philosophically though, I think we need to move away from warnings as they muddy the output and slip over time. I think we should go full on boolean on lint rules.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org