You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@parquet.apache.org by we...@apache.org on 2017/04/21 01:32:20 UTC
parquet-cpp git commit: PARQUET-961: Do not include debug symbols in
release builds by default
Repository: parquet-cpp
Updated Branches:
refs/heads/master f76dc4432 -> fdd8538bf
PARQUET-961: Do not include debug symbols in release builds by default
Author: Wes McKinney <we...@twosigma.com>
Closes #305 from wesm/PARQUET-961 and squashes the following commits:
fc0e029 [Wes McKinney] Do not include debug symbols in release builds by default
Project: http://git-wip-us.apache.org/repos/asf/parquet-cpp/repo
Commit: http://git-wip-us.apache.org/repos/asf/parquet-cpp/commit/fdd8538b
Tree: http://git-wip-us.apache.org/repos/asf/parquet-cpp/tree/fdd8538b
Diff: http://git-wip-us.apache.org/repos/asf/parquet-cpp/diff/fdd8538b
Branch: refs/heads/master
Commit: fdd8538bf6b45d94fb03ed55ed9831ee241548e3
Parents: f76dc44
Author: Wes McKinney <we...@twosigma.com>
Authored: Thu Apr 20 21:32:14 2017 -0400
Committer: Wes McKinney <we...@twosigma.com>
Committed: Thu Apr 20 21:32:14 2017 -0400
----------------------------------------------------------------------
CMakeLists.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/parquet-cpp/blob/fdd8538b/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 0809db4..389c09c 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -342,10 +342,11 @@ add_definitions(-fPIC)
# Same as DEBUG, except with -O1
# For CMAKE_BUILD_TYPE=Release
# -O3: Enable all compiler optimizations
-# -g: Enable symbols for profiler tools (TODO: remove for shipping)
+# Debug symbols are stripped for reduced binary size. Add
+# -DPARQUET_CXXFLAGS="-g" to include them
set(CXX_FLAGS_DEBUG "-ggdb -O0")
set(CXX_FLAGS_FASTDEBUG "-ggdb -O1")
-set(CXX_FLAGS_RELEASE "-O3 -g")
+set(CXX_FLAGS_RELEASE "-O3")
string (TOUPPER ${CMAKE_BUILD_TYPE} CMAKE_BUILD_TYPE)