[jira] [Resolved] (STORM-2599) BasicContainer.getWildcardDir tries to resolve the wildcard character with Paths.get, which prevents workers from booting on Windows

["Jungtaek Lim (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/STORM-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jungtaek Lim resolved STORM-2599.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 1.1.1
                   2.0.0

Thanks [~Srdo], I merged into master and 1.x branch.

> BasicContainer.getWildcardDir tries to resolve the wildcard character with Paths.get, which prevents workers from booting on Windows
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: STORM-2599
>                 URL: https://issues.apache.org/jira/browse/STORM-2599
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 1.1.1
>            Reporter: Stig Rohde Døssing
>            Assignee: Stig Rohde Døssing
>            Priority: Blocker
>             Fix For: 2.0.0, 1.1.1
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> STORM-2191 shortens the worker classpath by substituting in wildcards for the full list of jars. The path is constructed using Paths.get(dir, "*"), but this doesn't work on Windows. It seems like Windows checks that the path is valid. 
> {code}
> Paths.get(new File(".").toString(), "*");
> Exception in thread "main" java.nio.file.InvalidPathException: Illegal char <*> at index 2: .\*
> 	at sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182)
> 	at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153)
> 	at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)
> 	at sun.nio.fs.WindowsPath.parse(WindowsPath.java:94)
> 	at sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:255)
> 	at java.nio.file.Paths.get(Paths.java:84)
> {code}
> Paths doesn't guarantee support for globs, and we don't want the OS to examine the path in any case, since the wildcard isn't a "real" wildcard (including all files) but a special syntax for including jars in the Java classpath. The path should be constructed with String concatenation instead.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)