[jira] [Created] (SLING-3342) Do not use SlingBindings in Java code

["Bertrand Delacretaz (JIRA)" <ji...@apache.org>]

Bertrand Delacretaz created SLING-3342:
------------------------------------------

             Summary: Do not use SlingBindings in Java code
                 Key: SLING-3342
                 URL: https://issues.apache.org/jira/browse/SLING-3342
             Project: Sling
          Issue Type: Task
          Components: Best practices
            Reporter: Bertrand Delacretaz
            Assignee: Bertrand Delacretaz
            Priority: Minor


**DRAFT** - to be reviewed, and we need to update the SlingBindings javadocs as well.

SlingBindings is meant to be used in Sling scripts.

It might be available as a Request attribute in some cases, as Sling sets that before running scripts, but one cannot rely on that in java code.

There’s usually no reason to use it in Java code anyway, all the services that it provides are available directly, for example via an @Reference annotation.

Here’s a typical counter-example which should use an @Reference to the FooBar service instead:

// Do NOT do that!
SlingBindings bindings  (SlingBindings)request.getAttribute(SlingBindings.class.getName());
SlingScriptHelper scriptHelper = bindings.getSling();
FooBar fb = scriptHelper.getService(FoorBar.class);




--
This message was sent by Atlassian JIRA
(v6.1.5#6160)