You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/19 23:13:18 UTC

[GitHub] [incubator-nuttx] davids5 commented on pull request #1079: nxstyle: Fix distinction be source and header file for long lines.

davids5 commented on pull request #1079:
URL: https://github.com/apache/incubator-nuttx/pull/1079#issuecomment-631135587


   > For some unknow reason, long lines were reported as WARNING is header files, but as ERRORS in C source file.
   
   The reason was this:
   
   In past conversation you had told me that readability was more important than line length and that long lines were OK in arch headers. The code base reflected that. 
   
   But it is hard to teach a tool what any of that that means. 
    
   It is sad to me that the code has become less readable and information has been removed to accommodate the line length. I took pride in following your tradition of reflecting the datasheets in the headers.  
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org