[GitHub] [buildstream] juergbi commented on pull request #1537: Override project defined source mirrors, and be selective about what mirrors to use

[GitBox <gi...@apache.org>]

juergbi commented on pull request #1537:
URL: https://github.com/apache/buildstream/pull/1537#issuecomment-1013729799


   > Updated branch so that:
   > 
   >     * We remove the obsolete hard code which reverses URIs when tracking
   > 
   >     * Make the default track policy "aliases", so that (by default) we track only from original upstreams instead of mirrors which could be out of date
   
   This seems reasonable to me and the branch looks good to me - once the failing tests have been fixed.
   
   It might be possible to reduce the load on upstream/alias servers (at least for git) if we fetch from a mirror before we fetch from upstream for actual tracking. That way BuildStream would download very little from upstream, unless the mirror is out-of-date, without any risk of getting stale or wrong information from a mirror when tracking. However, I don't know whether this would be an important optimization. I certainly don't consider this a blocker for this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org