You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by interma <gi...@git.apache.org> on 2017/08/14 08:38:19 UTC
[GitHub] incubator-hawq pull request #1280: HAWQ-1510. Add TDE-related functionality ...
GitHub user interma opened a pull request:
https://github.com/apache/incubator-hawq/pull/1280
HAWQ-1510. Add TDE-related functionality into hawq init command
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/interma/interma-hawq HAWQ-1510-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1280.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1280
----
commit d312bea527927b845544e43347e0174c5eec032d
Author: interma <in...@outlook.com>
Date: 2017-08-14T08:30:45Z
HAWQ-1510. Add TDE-related functionality into hawq init command
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1280: HAWQ-1510. Add TDE-related functionality ...
Posted by interma <gi...@git.apache.org>.
Github user interma commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1280#discussion_r135429275
--- Diff: src/bin/gpcheckhdfs/gpcheckhdfs.c ---
@@ -6,9 +6,9 @@
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
--- End diff --
thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1280: HAWQ-1510. Add TDE-related functionality ...
Posted by stanlyxiang <gi...@git.apache.org>.
Github user stanlyxiang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1280#discussion_r134641796
--- Diff: src/bin/gpcheckhdfs/gpcheckhdfs.c ---
@@ -6,9 +6,9 @@
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
--- End diff --
just a reminder, we should not update license header unless there is a rat-check failure or necessary changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1280: HAWQ-1510. Add TDE-related functionality ...
Posted by amyrazz44 <gi...@git.apache.org>.
Github user amyrazz44 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1280#discussion_r132901535
--- Diff: src/bin/gpcheckhdfs/gpcheckhdfs.c ---
@@ -110,6 +114,12 @@ int main(int argc, char * argv[]) {
krb_keytabfile = argv[5];
}
+ //get tde key name param
+ for (int i = 1; i < argc; i++) {
+ if (strcmp(argv[i], "--with-tde") == 0 && i+1 < argc)
+ tde_keyname = argv[i+1];
--- End diff --
Add some comments in code about this will be better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1280: HAWQ-1510. Add TDE-related functionality into ha...
Posted by interma <gi...@git.apache.org>.
Github user interma commented on the issue:
https://github.com/apache/incubator-hawq/pull/1280
merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1280: HAWQ-1510. Add TDE-related functionality into ha...
Posted by amyrazz44 <gi...@git.apache.org>.
Github user amyrazz44 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1280
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1280: HAWQ-1510. Add TDE-related functionality ...
Posted by interma <gi...@git.apache.org>.
Github user interma closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1280
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1280: HAWQ-1510. Add TDE-related functionality ...
Posted by interma <gi...@git.apache.org>.
Github user interma commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1280#discussion_r132900269
--- Diff: src/bin/gpcheckhdfs/gpcheckhdfs.c ---
@@ -110,6 +114,12 @@ int main(int argc, char * argv[]) {
krb_keytabfile = argv[5];
}
+ //get tde key name param
+ for (int i = 1; i < argc; i++) {
+ if (strcmp(argv[i], "--with-tde") == 0 && i+1 < argc)
+ tde_keyname = argv[i+1];
--- End diff --
why not use `argv[6]` as the `tde_keyname`?
because the params before it may be empty...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1280: HAWQ-1510. Add TDE-related functionality into ha...
Posted by wengyanqing <gi...@git.apache.org>.
Github user wengyanqing commented on the issue:
https://github.com/apache/incubator-hawq/pull/1280
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1280: HAWQ-1510. Add TDE-related functionality ...
Posted by interma <gi...@git.apache.org>.
Github user interma commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1280#discussion_r133107473
--- Diff: src/bin/gpcheckhdfs/gpcheckhdfs.c ---
@@ -110,6 +114,12 @@ int main(int argc, char * argv[]) {
krb_keytabfile = argv[5];
}
+ //get tde key name param
+ for (int i = 1; i < argc; i++) {
+ if (strcmp(argv[i], "--with-tde") == 0 && i+1 < argc)
+ tde_keyname = argv[i+1];
--- End diff --
thanks, I will fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1280: HAWQ-1510. Add TDE-related functionality into ha...
Posted by interma <gi...@git.apache.org>.
Github user interma commented on the issue:
https://github.com/apache/incubator-hawq/pull/1280
@linwen @wengyanqing @amyrazz44 help to review, thanks.
Note:
Only include necessary code of **hawq-init**, other command modification will be added in another PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---