You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/10/27 18:27:00 UTC

[jira] [Commented] (IGNITE-10033) Update Grid(Ignite)CacheDatabaseSharedManager according to accepted coding guidelines

    [ https://issues.apache.org/jira/browse/IGNITE-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16666182#comment-16666182 ] 

ASF GitHub Bot commented on IGNITE-10033:
-----------------------------------------

GitHub user Mmuzaf opened a pull request:

    https://github.com/apache/ignite/pull/5156

    IGNITE-10033: fix logging according coding guidelines

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Mmuzaf/ignite ignite-10033

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/5156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5156
    
----
commit d771029a29462d4cf0b0f51cab5741f745e5391d
Author: Maxim Muzafarov <ma...@...>
Date:   2018-10-27T18:19:42Z

    IGNITE-10033: fix logging according coding guidelines

----


> Update Grid(Ignite)CacheDatabaseSharedManager according to accepted coding guidelines
> -------------------------------------------------------------------------------------
>
>                 Key: IGNITE-10033
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10033
>             Project: Ignite
>          Issue Type: Task
>            Reporter: Maxim Muzafarov
>            Assignee: Maxim Muzafarov
>            Priority: Minor
>
> We need to update minor issues according to Apache Ignite coding guidelines for {{IgniteCacheDatabaseSharedManager}} and {{GridCacheDatabaseSharedManager}} classes:
> * createDataRegionConfiguration method can be removed and simplified
> * startMemoryPolicies rename to startDataRegion
> * output messages format fix code style needed
> * fix format javadoc's
> * missed logging for cleanupCheckpointDirectory, cleanupCheckpointDirectory, cleanupWalDirectories



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)