You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "reluxa (via GitHub)" <gi...@apache.org> on 2023/08/03 16:24:48 UTC
[GitHub] [fineract] reluxa opened a new pull request, #3357: FINERACT-1724 - Fix testcases failing on the end of the month due to missing timezone configuration
reluxa opened a new pull request, #3357:
URL: https://github.com/apache/fineract/pull/3357
## Description
Testcases may fail at the end of the month. It is happening because of the testcase’s TZ is might not be in align with the servers timezone.
It is explained below using the testFixedDepositAccountWithPrematureClosureTypeWithdrawal_WITH_HOLD_TAX teastcase
Scenario #1, Tesctase running in UTC, time is 2023.08.31, 08:00 PM, Server is in Asia/Kolkata, so there the time is 2023.09.01 01:30 AM (UTC +5.5)
Fixed Deposit Account will be created with ACTIVATION_DATE = 2023.07.31, (Client time - 1 month)
Then client will trigger the posting of the interest
Server will calculate the interests, there is on 2023-08-01 and another on 2023-09-01
Testcase only expects a single interest in the expense ledger account, but we have two, so it will FAIL.
Scenario #2, Tesctase running in Asia/Kolkata, time is 2023.08.31, 08:00 PM, Server is in Asia/Kolkata, so there the time is 2023.08.31 08:00 PM
Fixed Deposit Account will be created with ACTIVATION_DATE = 2023.07.31, (Client time - 1 month)
Then client will trigger the posting of the interest
Server will calculate a single interest, there is on 2023-08-01
Testcase only expects a single interest and the amount is matching. PASS
Scenario #3, Tesctase running in UTC, time is 2023.09.01 02:00 AM, Server is in Asia/Kolkata, so there the time is 2023.09.01 07:30 AM (UTC +5.5)
Fixed Deposit Account will be created with ACTIVATION_DATE = 2023.08.1, (Client time - 1 month)
Then client will trigger the posting of the interest
Server will calculate the interests, there is on 2023-09-01
Testcase only expects a single interest be there, so it will PASS.
Scenario #4, Tesctase running in Asia/Kolkata, time is 2023.09.01 02:00 AM, Server is in Asia/Kolkata, so there the time is 2023.09.01 02:00 AM
Fixed Deposit Account will be created with ACTIVATION_DATE = 2023.08.1, (Client time - 1 month)
Then client will trigger the posting of the interest
Server will calculate the interests, there is on 2023-09-01
Testcase only expects a single interest be there, so it will PASS.
=> We need to make sure that client is always running using Asia/Kolkata TZ and the clock is in align with the server clock.
=> Server has a default tenant running using Asia/Kolkata TZ
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics merged pull request #3357: FINERACT-1724 - Fix testcases failing on the end of the month due to missing timezone configuration
Posted by "galovics (via GitHub)" <gi...@apache.org>.
galovics merged PR #3357:
URL: https://github.com/apache/fineract/pull/3357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org