You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/22 17:09:09 UTC

[GitHub] [arrow] ggodik commented on a diff in pull request #12960: ARROW-16823: [Go] Cleanup panics in new Buffered Reader

ggodik commented on code in PR #12960:
URL: https://github.com/apache/arrow/pull/12960#discussion_r856421573


##########
go/internal/utils/buf_reader.go:
##########
@@ -71,16 +78,17 @@ func (b *bufferedReader) fill() {
 	}
 
 	if b.w >= len(b.buf) {
-		panic("parquet/bufio: tried to fill full buffer")
+		return fmt.Errorf("arrow/bufferedreader: %w", bufio.ErrBufferFull)

Review Comment:
   You use errors.New and fmt.Errorf through-out the file.
   Is it worth consolidating or are they offering diff functionality?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org