[GitHub] jihoonson opened a new pull request #6086: Fix IllegalArgumentException in TaskLockBox.syncFromStorage() when updating from 0.12.x to 0.12.2

[GitBox <gi...@apache.org>]

jihoonson opened a new pull request #6086: Fix IllegalArgumentException in TaskLockBox.syncFromStorage() when updating from 0.12.x to 0.12.2
URL: https://github.com/apache/incubator-druid/pull/6086
 
 
   This bug was introduced in https://github.com/apache/incubator-druid/pull/6050. When updating the druid cluster from 0.12.x to 0.12.2, taskLocks in metastore should have the proper priority while tasks might not have it in taskContext. If priority isn't in taskContext, they return the default priority before #6050. But after #6050, tasks return 0 priority if priority doesn't exist in taskContext which causes this bug.
   
   In this patch, I changed the sanity check to pass if task doesn't have the priority and taskLock priority is same with task's default priority. Also added unit tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org