You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/18 06:02:58 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request, #7339: sched.h: Simplify HAVE_GROUP_MEMBERS logic
yamt opened a new pull request, #7339:
URL: https://github.com/apache/incubator-nuttx/pull/7339
## Summary
After the retirement of CONFIG_SCHED_EXIT_KILL_CHILDREN, [1] the behavior is now effectively controlled by
CONFIG_SCHED_CHILD_STATUS, which is IMO confusing. (It was even surprising me.)
This commit solves it by making HAVE_GROUP_MEMBERS a synonym of !CONFIG_DISABLE_PTHREAD. I guess this change aligns the intention of the CONFIG_SCHED_EXIT_KILL_CHILDREN retirement. That is, always tries to be similar to the standard behavior.
Another option would be to revive CONFIG_SCHED_EXIT_KILL_CHILDREN and make the HAVE_GROUP_MEMBERS logic aware of it. It might be a good idea if we want a finer-grained control of code to build. (One can argue his application uses pthread but does never _exit. In that case, it might be a waste to maintain group membership. I suspect it might not be too rare in embedded world.)
[1] commit 6982eb35feb2daba8a55d7f89c716c28aaf126e0
## Impact
- _exit behavior
- code/data size a bit
## Testing
tested with my app on sim on ubuntu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #7339: sched.h: Simplify HAVE_GROUP_MEMBERS logic
Posted by GitBox <gi...@apache.org>.
yamt commented on PR #7339:
URL: https://github.com/apache/incubator-nuttx/pull/7339#issuecomment-1283789836
> > @yamt the linker error need be addressed before merging.
>
> ```
> ====================================================================================
> Configuration/Tool: sabre-6quad/netknsh,CONFIG_ARM_TOOLCHAIN_GNU_EABI
> ------------------------------------------------------------------------------------
> Cleaning...
> Configuring...
> Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
> Enabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
> Building NuttX...
> % Total % Received % Xferd Average Speed Time Time Time Current
> Dload Upload Total Spent Left Speed
>
> 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
> 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
>
> 100 496k 100 496k 0 0 4034k 0 --:--:-- --:--:-- --:--:-- 4034k
> arm-none-eabi-ld: /github/workspace/sources/nuttx/staging/libsched.a(group_killchildren.o): in function `group_kill_children_handler':
> /github/workspace/sources/nuttx/sched/group/group_killchildren.c:95: undefined reference to `task_delete'
> make[1]: *** [Makefile:174: nuttx] Error 1
> make: *** [tools/Unix.mk:509: nuttx] Error 2
> ```
fixed. thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7339: sched.h: Simplify HAVE_GROUP_MEMBERS logic
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7339:
URL: https://github.com/apache/incubator-nuttx/pull/7339#issuecomment-1282632566
@yamt the linker error need be addressed before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #7339: sched.h: Simplify HAVE_GROUP_MEMBERS logic
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #7339:
URL: https://github.com/apache/incubator-nuttx/pull/7339#issuecomment-1283098161
>@yamt the linker error need be addressed before merging.
```
====================================================================================
Configuration/Tool: sabre-6quad/netknsh,CONFIG_ARM_TOOLCHAIN_GNU_EABI
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
Enabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
Building NuttX...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 496k 100 496k 0 0 4034k 0 --:--:-- --:--:-- --:--:-- 4034k
arm-none-eabi-ld: /github/workspace/sources/nuttx/staging/libsched.a(group_killchildren.o): in function `group_kill_children_handler':
/github/workspace/sources/nuttx/sched/group/group_killchildren.c:95: undefined reference to `task_delete'
make[1]: *** [Makefile:174: nuttx] Error 1
make: *** [tools/Unix.mk:509: nuttx] Error 2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7339: sched.h: Simplify HAVE_GROUP_MEMBERS logic
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7339:
URL: https://github.com/apache/incubator-nuttx/pull/7339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org