You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2022/11/09 09:12:50 UTC

[GitHub] [incubator-livy] dohongdayi opened a new pull request, #332: [LIVY-871] Add client config to keep fields of table magic in query order

dohongdayi opened a new pull request, #332:
URL: https://github.com/apache/incubator-livy/pull/332

   ## What changes were proposed in this pull request?
   
   Currently the fields in table magic are sorted by field name by default, but in many scenarios, we want to keep fields of table magic in query order, for example:
   
   `val result = spark.sql("select b, a from table")`
   `%table result`
   
   currently Livy responses json with fields in the order of "a", "b", but we want them in the order of "b", "a" which is consistent with the SQL
   
   JIRA: https://issues.apache.org/jira/browse/LIVY-871
   
   fix #871
   
   ## How was this patch tested?
   
   existing tests & new tests in ScalaInterpreterSpec.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@livy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-livy] yantzu closed pull request #332: [LIVY-871] Add client config to keep fields of table magic in query order

Posted by GitBox <gi...@apache.org>.
yantzu closed pull request #332: [LIVY-871] Add client config to keep fields of table magic in query order
URL: https://github.com/apache/incubator-livy/pull/332


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@livy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-livy] yantzu commented on pull request #332: [LIVY-871] Add client config to keep fields of table magic in query order

Posted by GitBox <gi...@apache.org>.
yantzu commented on PR #332:
URL: https://github.com/apache/incubator-livy/pull/332#issuecomment-1308444538

   Retrigger the test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@livy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org