You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "qg-lin (via GitHub)" <gi...@apache.org> on 2024/09/20 09:35:00 UTC
[PR] [minor][cdc-connector][mongodb] Add `op_type` metadata column [flink-cdc]
qg-lin opened a new pull request, #3615:
URL: https://github.com/apache/flink-cdc/pull/3615
Add `op_type` metadata column for mongodb source connector
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [minor][cdc-connector][mongodb] Add `op_type` metadata column [flink-cdc]
Posted by "qg-lin (via GitHub)" <gi...@apache.org>.
qg-lin commented on PR #3615:
URL: https://github.com/apache/flink-cdc/pull/3615#issuecomment-2375852444
Since DeduplicateFunctionHelper#processLastRowOnChangelog returns the row before deletion, the `delete` type is temporarily missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [minor][cdc-connector][mongodb] Add `op_type` metadata column [flink-cdc]
Posted by "qg-lin (via GitHub)" <gi...@apache.org>.
qg-lin commented on PR #3615:
URL: https://github.com/apache/flink-cdc/pull/3615#issuecomment-2363291818
@Jiabao-Sun @yuxiqian PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [minor][cdc-connector][mongodb] Add `op_type` metadata column [flink-cdc]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3615:
URL: https://github.com/apache/flink-cdc/pull/3615#issuecomment-2499282744
This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [minor][cdc-connector][mongodb] Add `op_type` metadata column [flink-cdc]
Posted by "Jiabao-Sun (via GitHub)" <gi...@apache.org>.
Jiabao-Sun commented on code in PR #3615:
URL: https://github.com/apache/flink-cdc/pull/3615#discussion_r1768333821
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mongodb-cdc/src/test/java/org/apache/flink/cdc/connectors/mongodb/source/MongoDBFullChangelogITCase.java:
##########
@@ -648,6 +648,7 @@ private void testMongoDBParallelSource(
+ " name STRING,"
+ " address STRING,"
+ " phone_number STRING,"
+ + " op_type STRING METADATA FROM 'op_type' VIRTUAL,"
Review Comment:
Thanks @qg-lin for this improvement.
How about add this case into `MongoDBConnectorITCase#testMetadataColumns`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [minor][cdc-connector][mongodb] Add `op_type` metadata column [flink-cdc]
Posted by "yuxiqian (via GitHub)" <gi...@apache.org>.
yuxiqian commented on code in PR #3615:
URL: https://github.com/apache/flink-cdc/pull/3615#discussion_r1772561223
##########
docs/content.zh/docs/connectors/flink-sources/mongodb-cdc.md:
##########
@@ -332,6 +332,11 @@ upstart 流需要一个唯一的密钥，所以我们必须声明 `_id` 作为
<td>TIMESTAMP_LTZ(3) NOT NULL</td>
<td>它指示在数据库中进行更改的时间。 <br>如果记录是从表的快照而不是改变流中读取的，该值将始终为0。</td>
</tr>
+ <tr>
+ <td>op_type</td>
+ <td>STRING NOT NULL</td>
+ <td>该行的操作类型。</td>
Review Comment:
What about listing all possible values of `op_type` since it's enumerable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [minor][cdc-connector][mongodb] Add `op_type` metadata column [flink-cdc]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3615:
URL: https://github.com/apache/flink-cdc/pull/3615#issuecomment-2563181213
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [minor][cdc-connector][mongodb] Add `op_type` metadata column [flink-cdc]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #3615: [minor][cdc-connector][mongodb] Add `op_type` metadata column
URL: https://github.com/apache/flink-cdc/pull/3615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org