You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2012/03/14 18:43:36 UTC
svn commit: r1300661 -
/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
Author: sebb
Date: Wed Mar 14 17:43:35 2012
New Revision: 1300661
URL: http://svn.apache.org/viewvc?rev=1300661&view=rev
Log:
CSV-60 CSVParser.iterator().remove() should throw throw new UnsupportedOperationException()
Modified:
commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
Modified: commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
URL: http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java?rev=1300661&r1=1300660&r2=1300661&view=diff
==============================================================================
--- commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java (original)
+++ commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java Wed Mar 14 17:43:35 2012
@@ -212,7 +212,9 @@ public class CSVParser implements Iterab
}
}
- public void remove() { }
+ public void remove() {
+ throw new UnsupportedOperationException();
+ }
};
}
Re: svn commit: r1300661 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
Posted by Benedikt Ritter <be...@googlemail.com>.
Am 14. März 2012 20:33 schrieb Benedikt Ritter <be...@googlemail.com>:
> Am 14. März 2012 18:43 schrieb <se...@apache.org>:
>> Author: sebb
>> Date: Wed Mar 14 17:43:35 2012
>> New Revision: 1300661
>>
>> URL: http://svn.apache.org/viewvc?rev=1300661&view=rev
>> Log:
>> CSV-60 CSVParser.iterator().remove() should throw throw new UnsupportedOperationException()
>>
>
> is it reasonable to add a unit test, that makes sure an
> UnsupportedOperationException is thrown?
>
just saw the second commit on this one. Forget it.
>> Modified:
>> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
>>
>> Modified: commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
>> URL: http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java?rev=1300661&r1=1300660&r2=1300661&view=diff
>> ==============================================================================
>> --- commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java (original)
>> +++ commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java Wed Mar 14 17:43:35 2012
>> @@ -212,7 +212,9 @@ public class CSVParser implements Iterab
>> }
>> }
>>
>> - public void remove() { }
>> + public void remove() {
>> + throw new UnsupportedOperationException();
>> + }
>> };
>> }
>>
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1300661 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
Posted by Benedikt Ritter <be...@googlemail.com>.
Am 14. März 2012 18:43 schrieb <se...@apache.org>:
> Author: sebb
> Date: Wed Mar 14 17:43:35 2012
> New Revision: 1300661
>
> URL: http://svn.apache.org/viewvc?rev=1300661&view=rev
> Log:
> CSV-60 CSVParser.iterator().remove() should throw throw new UnsupportedOperationException()
>
is it reasonable to add a unit test, that makes sure an
UnsupportedOperationException is thrown?
> Modified:
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
>
> Modified: commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
> URL: http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java?rev=1300661&r1=1300660&r2=1300661&view=diff
> ==============================================================================
> --- commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java (original)
> +++ commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java Wed Mar 14 17:43:35 2012
> @@ -212,7 +212,9 @@ public class CSVParser implements Iterab
> }
> }
>
> - public void remove() { }
> + public void remove() {
> + throw new UnsupportedOperationException();
> + }
> };
> }
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org