You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Vladimir Loncar (JIRA)" <ji...@apache.org> on 2010/11/05 13:43:43 UTC
[jira] Created: (CASSANDRA-1713) Windows batch files use incorrect
paths
Windows batch files use incorrect paths
---------------------------------------
Key: CASSANDRA-1713
URL: https://issues.apache.org/jira/browse/CASSANDRA-1713
Project: Cassandra
Issue Type: Bug
Environment: Windows
Reporter: Vladimir Loncar
Priority: Minor
Windows .bat files (with the exception of cassandra.bat) use %CD% to set CASSANDRA_HOME, and since that is incorrect, they fail to start with ClassNotFoundException.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1713) Windows batch files use
incorrect paths
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929816#action_12929816 ]
Jonathan Ellis commented on CASSANDRA-1713:
-------------------------------------------
what is the trick to apply? fails for me against 0.7 and 0.6
> Windows batch files use incorrect paths
> ---------------------------------------
>
> Key: CASSANDRA-1713
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1713
> Project: Cassandra
> Issue Type: Bug
> Environment: Windows
> Reporter: Vladimir Loncar
> Priority: Minor
> Attachments: windows-batch-fix.patch
>
>
> Windows .bat files (with the exception of cassandra.bat) use %CD% to set CASSANDRA_HOME, and since that is incorrect, they fail to start with ClassNotFoundException.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1713) Windows batch files use
incorrect paths
Posted by "Vladimir Loncar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930022#action_12930022 ]
Vladimir Loncar commented on CASSANDRA-1713:
--------------------------------------------
I created the patch with diff, and tested it with patch tool, both from GnuWin32 package. It works on both 0.6 and 0.7, although on 0.6 there is one line of offset (it still applies successfully). I also noticed that cassandra.bat in 0.7 sets CASSANDRA_CONF, and i dont see it being used (conf dir gets on classpath a few lines later, so this seems redundant). I tested without it, and it appears to work normally. Should i also include that in the patch?
On a related note, what is needed to bring cassandra up to par on windows? I know there are some JNA enhancements, and now direct IO which are Linux-only, but there are probably more I am not aware of. Maybe opening a ticket to track these wouldn't be a bad idea?
> Windows batch files use incorrect paths
> ---------------------------------------
>
> Key: CASSANDRA-1713
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1713
> Project: Cassandra
> Issue Type: Bug
> Environment: Windows
> Reporter: Vladimir Loncar
> Priority: Minor
> Attachments: windows-batch-fix.patch
>
>
> Windows .bat files (with the exception of cassandra.bat) use %CD% to set CASSANDRA_HOME, and since that is incorrect, they fail to start with ClassNotFoundException.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-1713) Windows batch files use incorrect
paths
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-1713.
---------------------------------------
Resolution: Fixed
Fix Version/s: 0.7.0
0.6.8
Reviewer: bcoverston
Assignee: Vladimir Loncar
committed.
bq. what is the trick to apply
for the record: dos2unix bin/*.bat; patch; unix2dos bin/*.bat. If there is a way to get patch to deal with targets with CLRF line endings, I couldn't find it. (It deals w/ CLRF in the _patch_ just fine.)
bq. I also noticed that cassandra.bat in 0.7 sets CASSANDRA_CONF, and i dont see it being used
removed in the merge to 0.7
bq. what is needed to bring cassandra up to par on windows? I know there are some JNA enhancements, and now direct IO which are Linux-only
I think that's about it really (besides CASSANDRA-292). The JNA stuff is all in CLibrary -- extracting the higher-level code to another class, and using CLibrary/WindowsLibrary (what is the equivalent of libc?) from that depending on platform is probably the way to go.
bq. Maybe opening a ticket to track these
I'd say open a ticket if you're going to work on it. :)
> Windows batch files use incorrect paths
> ---------------------------------------
>
> Key: CASSANDRA-1713
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1713
> Project: Cassandra
> Issue Type: Bug
> Components: Packaging
> Environment: Windows
> Reporter: Vladimir Loncar
> Assignee: Vladimir Loncar
> Priority: Minor
> Fix For: 0.6.8, 0.7.0
>
> Attachments: windows-batch-fix.patch
>
>
> Windows .bat files (with the exception of cassandra.bat) use %CD% to set CASSANDRA_HOME, and since that is incorrect, they fail to start with ClassNotFoundException.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1713) Windows batch files use
incorrect paths
Posted by "Benjamin Coverston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929761#action_12929761 ]
Benjamin Coverston commented on CASSANDRA-1713:
-----------------------------------------------
+1 this looks good. Thanks!
> Windows batch files use incorrect paths
> ---------------------------------------
>
> Key: CASSANDRA-1713
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1713
> Project: Cassandra
> Issue Type: Bug
> Environment: Windows
> Reporter: Vladimir Loncar
> Priority: Minor
> Attachments: windows-batch-fix.patch
>
>
> Windows .bat files (with the exception of cassandra.bat) use %CD% to set CASSANDRA_HOME, and since that is incorrect, they fail to start with ClassNotFoundException.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1713) Windows batch files use incorrect
paths
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1713:
--------------------------------------
Component/s: Packaging
> Windows batch files use incorrect paths
> ---------------------------------------
>
> Key: CASSANDRA-1713
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1713
> Project: Cassandra
> Issue Type: Bug
> Components: Packaging
> Environment: Windows
> Reporter: Vladimir Loncar
> Assignee: Vladimir Loncar
> Priority: Minor
> Fix For: 0.6.8, 0.7.0
>
> Attachments: windows-batch-fix.patch
>
>
> Windows .bat files (with the exception of cassandra.bat) use %CD% to set CASSANDRA_HOME, and since that is incorrect, they fail to start with ClassNotFoundException.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1713) Windows batch files use incorrect
paths
Posted by "Vladimir Loncar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vladimir Loncar updated CASSANDRA-1713:
---------------------------------------
Attachment: windows-batch-fix.patch
> Windows batch files use incorrect paths
> ---------------------------------------
>
> Key: CASSANDRA-1713
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1713
> Project: Cassandra
> Issue Type: Bug
> Environment: Windows
> Reporter: Vladimir Loncar
> Priority: Minor
> Attachments: windows-batch-fix.patch
>
>
> Windows .bat files (with the exception of cassandra.bat) use %CD% to set CASSANDRA_HOME, and since that is incorrect, they fail to start with ClassNotFoundException.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.