[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #9243: [IOTDB-5674] Multi-Mode IMNode Management

["MarcosZyk (via GitHub)" <gi...@apache.org>]

MarcosZyk commented on code in PR #9243:
URL: https://github.com/apache/iotdb/pull/9243#discussion_r1136444514


##########
server/src/main/java/org/apache/iotdb/db/metadata/mtree/store/IMTreeStore.java:
##########
@@ -61,33 +61,33 @@ public interface IMTreeStore {
    * @param name name or alias
    * @return child node
    */
-  IMNode getChild(IMNode parent, String name) throws MetadataException;
+  N getChild(N parent, String name) throws MetadataException;
 
-  IMNodeIterator getChildrenIterator(IMNode parent) throws MetadataException;
+  IMNodeIterator<N> getChildrenIterator(N parent) throws MetadataException;
 
-  IMNodeIterator getTraverserIterator(
-      IMNode parent, Map<Integer, Template> templateMap, boolean skipPreDeletedSchema)
+  IMNodeIterator<N> getTraverserIterator(
+      N parent, Map<Integer, Template> templateMap, boolean skipPreDeletedSchema)
       throws MetadataException;
 
-  IMNode addChild(IMNode parent, String childName, IMNode child);
+  N addChild(N parent, String childName, N child);
 
-  void deleteChild(IMNode parent, String childName) throws MetadataException;
+  void deleteChild(N parent, String childName) throws MetadataException;
 
-  void updateMNode(IMNode node) throws MetadataException;
+  void updateMNode(N node) throws MetadataException;
 
-  IEntityMNode setToEntity(IMNode node) throws MetadataException;
+  IDeviceMNode<N> setToEntity(N node) throws MetadataException;
 
-  IMNode setToInternal(IEntityMNode entityMNode) throws MetadataException;
+  N setToInternal(IDeviceMNode<N> entityMNode) throws MetadataException;
 
-  void setAlias(IMeasurementMNode measurementMNode, String alias) throws MetadataException;
+  void setAlias(IMeasurementMNode<N> measurementMNode, String alias) throws MetadataException;
 
-  void pin(IMNode node) throws MetadataException;
+  void pin(N node) throws MetadataException;
 
-  void unPin(IMNode node);
+  void unPin(N node);
 
-  void unPinPath(IMNode node);
+  void unPinPath(N node);

Review Comment:
   At least the Traverser shall not sense these interface? It takes a big effort to refactor the implementations in SchemaRegionSchemaFileImpl.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org