You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2013/03/18 18:11:09 UTC
svn commit: r1457869 -
/commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/CollectionUtilsTest.java
Author: ggregory
Date: Mon Mar 18 17:11:08 2013
New Revision: 1457869
URL: http://svn.apache.org/r1457869
Log:
Always use a block.
Modified:
commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/CollectionUtilsTest.java
Modified: commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/CollectionUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/CollectionUtilsTest.java?rev=1457869&r1=1457868&r2=1457869&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/CollectionUtilsTest.java (original)
+++ commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/CollectionUtilsTest.java Mon Mar 18 17:11:08 2013
@@ -515,8 +515,11 @@ public class CollectionUtilsTest extends
// odd / even equator
final Equator<Integer> e = new Equator<Integer>() {
public boolean equate(Integer o1, Integer o2) {
- if (o1.intValue() % 2 == 0 ^ o2.intValue() % 2 == 0) return false;
- else return true;
+ if (o1.intValue() % 2 == 0 ^ o2.intValue() % 2 == 0) {
+ return false;
+ } else {
+ return true;
+ }
}
public int hash(Integer o) {
Re: svn commit: r1457869 - /commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/CollectionUtilsTest.java
Posted by Simone Tripodi <si...@apache.org>.
Sure! I hope anyway that a good part of common sense would stop RMs on
going ahead in front of critical issues :P
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Tue, Mar 19, 2013 at 3:10 PM, Matt Benson <gu...@gmail.com> wrote:
> Well, but given that a release cannot be vetoed, it's probably better to
> catch fundamental design problems earlier rather than later.
>
> Matt
>
>
> On Tue, Mar 19, 2013 at 2:12 AM, Simone Tripodi <si...@apache.org>wrote:
>
>> >> I 150% agree with you mate - it's pity here we regularly miss both the
>> >> `early` and the `often` :)
>> >
>> > The downside is that if you rush out a release and it contains a
>> > broken API it will be very difficult to fix without causing problems
>> > for end-users.
>>
>> that is why we vote releases, right?
>>
>> http://people.apache.org/~simonetripodi/
>> http://simonetripodi.livejournal.com/
>> http://twitter.com/simonetripodi
>> http://www.99soft.org/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1457869 - /commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/CollectionUtilsTest.java
Posted by Matt Benson <gu...@gmail.com>.
Well, but given that a release cannot be vetoed, it's probably better to
catch fundamental design problems earlier rather than later.
Matt
On Tue, Mar 19, 2013 at 2:12 AM, Simone Tripodi <si...@apache.org>wrote:
> >> I 150% agree with you mate - it's pity here we regularly miss both the
> >> `early` and the `often` :)
> >
> > The downside is that if you rush out a release and it contains a
> > broken API it will be very difficult to fix without causing problems
> > for end-users.
>
> that is why we vote releases, right?
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: svn commit: r1457869 - /commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/CollectionUtilsTest.java
Posted by Simone Tripodi <si...@apache.org>.
>> I 150% agree with you mate - it's pity here we regularly miss both the
>> `early` and the `often` :)
>
> The downside is that if you rush out a release and it contains a
> broken API it will be very difficult to fix without causing problems
> for end-users.
that is why we vote releases, right?
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1457869 - /commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/CollectionUtilsTest.java
Posted by sebb <se...@gmail.com>.
On 18 March 2013 20:31, Simone Tripodi <si...@apache.org> wrote:
>> but there are too many discussions about checkstyle rules and "perfect"
>> releases. We should aim to follow more the open-source credo: release
>> early, release often, imho.
>
> I 150% agree with you mate - it's pity here we regularly miss both the
> `early` and the `often` :)
The downside is that if you rush out a release and it contains a
broken API it will be very difficult to fix without causing problems
for end-users.
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1457869 - /commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/CollectionUtilsTest.java
Posted by Simone Tripodi <si...@apache.org>.
> but there are too many discussions about checkstyle rules and "perfect"
> releases. We should aim to follow more the open-source credo: release
> early, release often, imho.
I 150% agree with you mate - it's pity here we regularly miss both the
`early` and the `often` :)
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1457869 - /commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/CollectionUtilsTest.java
Posted by Thomas Neidhart <th...@gmail.com>.
On 03/18/2013 09:04 PM, Simone Tripodi wrote:
> we were just kidding, mate :D
>
> you didn't get our sense of humor ;)
I got that ;-),
but there are too many discussions about checkstyle rules and "perfect"
releases. We should aim to follow more the open-source credo: release
early, release often, imho.
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1457869 - /commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/CollectionUtilsTest.java
Posted by Simone Tripodi <si...@apache.org>.
we were just kidding, mate :D
you didn't get our sense of humor ;)
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Mon, Mar 18, 2013 at 8:56 PM, Thomas Neidhart
<th...@gmail.com> wrote:
> On 03/18/2013 08:44 PM, Simone Tripodi wrote:
>>>
>>> Are you sure, that we don't have a checkstyle rule for too smart code?
>>>
>>> ;-)
>>
>> lol, that violates the `Avoid inline conditionals.` rule! :D
>
> checkstyle is just a tool, not our master!
>
> Disable the rules that do not make sense,
>
> just my 2c
>
> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1457869 - /commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/CollectionUtilsTest.java
Posted by Thomas Neidhart <th...@gmail.com>.
On 03/18/2013 08:44 PM, Simone Tripodi wrote:
>>
>> Are you sure, that we don't have a checkstyle rule for too smart code?
>>
>> ;-)
>
> lol, that violates the `Avoid inline conditionals.` rule! :D
checkstyle is just a tool, not our master!
Disable the rules that do not make sense,
just my 2c
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1457869 - /commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/CollectionUtilsTest.java
Posted by Simone Tripodi <si...@apache.org>.
>
> Are you sure, that we don't have a checkstyle rule for too smart code?
>
> ;-)
lol, that violates the `Avoid inline conditionals.` rule! :D
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1457869 - /commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/CollectionUtilsTest.java
Posted by Jörg Schaible <jo...@gmx.de>.
Simone Tripodi wrote:
>> Well, it could be recoded like this:
>>
>> return !(o1.intValue() % 2 == 0 ^ o2.intValue() % 2 == 0);
>>
>> which is not really clearer but it is fewer chars..
>>
>> Gary
>>
>
> well, looks smart to me! :)
Are you sure, that we don't have a checkstyle rule for too smart code?
;-)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1457869 - /commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/CollectionUtilsTest.java
Posted by Simone Tripodi <si...@apache.org>.
> Well, it could be recoded like this:
>
> return !(o1.intValue() % 2 == 0 ^ o2.intValue() % 2 == 0);
>
> which is not really clearer but it is fewer chars..
>
> Gary
>
well, looks smart to me! :)
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1457869 - /commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/CollectionUtilsTest.java
Posted by Gary Gregory <ga...@gmail.com>.
Well, it could be recoded like this:
return !(o1.intValue() % 2 == 0 ^ o2.intValue() % 2 == 0);
which is not really clearer but it is fewer chars..
Gary
On Mon, Mar 18, 2013 at 1:25 PM, Gary Gregory <ga...@gmail.com>wrote:
> Sure, makes sense.
>
> Gary
>
>
> On Mon, Mar 18, 2013 at 1:22 PM, Simone Tripodi <si...@apache.org>wrote:
>
>> Salut Gary,
>>
>> > + if (o1.intValue() % 2 == 0 ^ o2.intValue() % 2 == 0) {
>> > + return false;
>> > + } else {
>> > + return true;
>> > + }
>>
>> FWIW, you don't need the `else` here.
>>
>> my 2 cents,
>> -Simo
>>
>> http://people.apache.org/~simonetripodi/
>> http://simonetripodi.livejournal.com/
>> http://twitter.com/simonetripodi
>> http://www.99soft.org/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1457869 - /commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/CollectionUtilsTest.java
Posted by Gary Gregory <ga...@gmail.com>.
Sure, makes sense.
Gary
On Mon, Mar 18, 2013 at 1:22 PM, Simone Tripodi <si...@apache.org>wrote:
> Salut Gary,
>
> > + if (o1.intValue() % 2 == 0 ^ o2.intValue() % 2 == 0) {
> > + return false;
> > + } else {
> > + return true;
> > + }
>
> FWIW, you don't need the `else` here.
>
> my 2 cents,
> -Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1457869 - /commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/CollectionUtilsTest.java
Posted by Simone Tripodi <si...@apache.org>.
Salut Gary,
> + if (o1.intValue() % 2 == 0 ^ o2.intValue() % 2 == 0) {
> + return false;
> + } else {
> + return true;
> + }
FWIW, you don't need the `else` here.
my 2 cents,
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org