You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/10/17 00:47:36 UTC

[GitHub] [beam] dpcollins-google commented on a change in pull request #15727: [BEAM-13052] Add Pub/Sub Lite xlang transforms in python

dpcollins-google commented on a change in pull request #15727:
URL: https://github.com/apache/beam/pull/15727#discussion_r730286504



##########
File path: sdks/python/apache_beam/io/gcp/pubsublite/external.py
##########
@@ -0,0 +1,119 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with

Review comment:
       I'd prefer not to- the usage from a user perspective is identical whether the file is pubsbulite.py or pubsublite/__init__.py, and the latter provides better isolation of Pub/Sub Lite specific files.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org