You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/05/07 08:37:51 UTC

[GitHub] [cloudstack] kioie opened a new pull request #3484: List CPU Sockets Metrics API: Combines CPU Socket Metrics For All Hypervisors

kioie opened a new pull request #3484:
URL: https://github.com/apache/cloudstack/pull/3484


   ## Description
   <!--- Describe your changes in detail -->
   Picks up on the work of @niteshsarda on PR #2440
   Separating API work from UI changes, for easier management and review
   
   **Requirement :**
   
   Introduce a new API to collect and list CPU Sockets Metrics information for each hypervisor. Currently, listHosts API is fired for each hypervisor seprately to retrieve the count of CPU sockets. So, with this fix instead of multiple API execution, single API query will be executed to reterieve information for all the hypervisors.
   
   **Implementation :**
   
   1. Introduced a new API namely "listCpuSocketsMetrics", which will fetch details of CPU Sockets for all the hypervisors in a single run.
   2. In this API, a query will be fired on a host table to fetch details based on grouping of Hypervisor type and Hypervisor version.
   3. This API will prevent multiple calls of listHosts API and thus will improve performance of the infrastructure tab.
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   `list cpusocketsmetrics`
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] kioie commented on pull request #3484: List CPU Sockets Metrics API: Combines CPU Socket Metrics For All Hypervisors

Posted by GitBox <gi...@apache.org>.
kioie commented on pull request #3484:
URL: https://github.com/apache/cloudstack/pull/3484#issuecomment-635109011


   Hi Dan, no, not really. Feature included in PR #1944


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] kioie closed pull request #3484: List CPU Sockets Metrics API: Combines CPU Socket Metrics For All Hypervisors

Posted by GitBox <gi...@apache.org>.
kioie closed pull request #3484:
URL: https://github.com/apache/cloudstack/pull/3484


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #3484: List CPU Sockets Metrics API: Combines CPU Socket Metrics For All Hypervisors

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3484:
URL: https://github.com/apache/cloudstack/pull/3484#issuecomment-625115818


   @kioie Do you still want this (in 4.15 or beyond)?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org