You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/05/19 04:08:59 UTC
[PR] ci(e2e): run backend under gunicorn instead of flask dev server [superset]
rusackas opened a new pull request, #40234:
URL: https://github.com/apache/superset/pull/40234
### SUMMARY
The E2E (Playwright + Cypress) workflows on master have a 12% flake rate (6 of last 50 runs), and every failure looks the same:
```
[testAssets] Failed to cleanup dashboard 13: Error: Missing CSRF token
(Error: apiRequestContext.get: socket hang up
✘ Dashboard Export › should download ZIP and show success toast when clicking Export YAML
Error: page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:8081/...
TimeoutError: page.waitForFunction: Timeout 15000ms exceeded
Error: page.goto: net::ERR_ABORTED; maybe frame was detached?
```
The trigger is always one of the heavy dashboard ZIP import/export tests:
- `playwright/tests/dashboard/export.spec.ts:61` — *Dashboard Export › should download ZIP and show success toast when clicking Export YAML*
- `playwright/tests/dashboard/dashboard-list.spec.ts:266` — *import dashboard › should import a dashboard from a zip file*
Both `cypress-run-all` and `playwright-run` in [`.github/workflows/bashlib.sh`](https://github.com/apache/superset/blob/master/.github/workflows/bashlib.sh) start the backend with `flask run --no-debugger -p $port`. The Flask development server is single-threaded with no crash recovery, so when these tests overwhelm it the backend stays dead for the rest of the suite — every test afterward cascades into `ECONNREFUSED`.
This PR switches both runners to **gunicorn** with the same shape used in [`docker/entrypoints/run-server.sh`](https://github.com/apache/superset/blob/master/docker/entrypoints/run-server.sh):
- `--workers 4 --worker-class gthread --threads 20` — real concurrency, matching what production runs.
- `--timeout 120` — kill stuck workers instead of letting them hang the entire suite.
- `--max-requests 500 --max-requests-jitter 50` — recycle workers periodically so memory accumulation doesn't OOM the process.
- `--access-logfile - --error-logfile -` — keeps the existing per-run log capture pattern.
### BEFORE/AFTER
| | Before | After |
|---|---|---|
| Backend | `flask run --no-debugger` (single-threaded dev server) | `gunicorn` with 4 workers × 20 threads |
| Crash recovery | None (one worker = the only worker) | Workers auto-recycle on crash + every 500 requests |
| Timeout | None (hangs indefinitely) | 120s per worker |
| Documented purpose | "development only" — Flask docs explicitly say not to use under load | Production-grade WSGI server |
### TESTING INSTRUCTIONS
This PR is a CI-only change. To validate:
1. Push a commit (this PR's CI run will exercise it on a real GitHub runner).
2. Compare the failure rate of the `E2E / playwright-tests` and `cypress-matrix` jobs against the baseline (~12% on master right now).
3. The cleanup `[testAssets] Failed to cleanup` warnings should largely disappear, since the backend stays alive throughout each test file.
### ADDITIONAL INFORMATION
- [ ] Has associated issue
- [ ] Required feature flags
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
Only frontend (JS) coverage is captured in E2E (verified — `bashlib.sh` only instruments JS assets via `build-instrumented-assets`), so multi-worker gunicorn doesn't break the existing coverage path.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] ci(e2e): run backend under gunicorn instead of flask dev server [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #40234:
URL: https://github.com/apache/superset/pull/40234#discussion_r3263706823
##########
.github/workflows/bashlib.sh:
##########
@@ -187,7 +190,18 @@ cypress-run-all() {
fi
export CYPRESS_BASE_URL
- nohup flask run --no-debugger -p $port >"$flasklog" 2>&1 </dev/null &
+ nohup gunicorn \
+ --bind "127.0.0.1:$port" \
+ --workers 4 \
+ --worker-class gthread \
+ --threads 20 \
+ --timeout 120 \
+ --max-requests 500 \
+ --max-requests-jitter 50 \
+ --access-logfile - \
+ --error-logfile - \
+ "superset.app:create_app()" \
+ >"$flasklog" 2>&1 </dev/null &
local flaskProcessId=$!
Review Comment:
Good catch — fixed in 053adcd6. `cypress-run-all` now polls `/health` for up to 60s before launching Cypress (same shape as `playwright-run`), and prints the gunicorn startup log + fails fast if the server doesn't come up.
##########
.github/workflows/bashlib.sh:
##########
@@ -175,9 +175,12 @@ cypress-run-all() {
local APP_ROOT=$2
cd "$GITHUB_WORKSPACE/superset-frontend/cypress-base"
- # Start Flask and run it in background
- # --no-debugger means disable the interactive debugger on the 500 page
- # so errors can print to stderr.
+ # Start the Superset backend via gunicorn (not `flask run`). The Flask
+ # development server is single-threaded and has no crash-recovery, so
+ # heavy tests (dashboard import/export, SQL Lab) can knock it offline
+ # for the rest of the run — surfacing as `ECONNREFUSED` / `socket hang up`
+ # / `Missing CSRF token` cascades. Gunicorn gives us multiple workers,
+ # a request timeout, and worker-recycling under load.
local flasklog="${HOME}/flask.log"
local port=8081
Review Comment:
Renamed in 053adcd6 — `flasklog` → `serverlog`, `flaskProcessId` → `serverPid`, log groups now say "gunicorn log for Cypress/Playwright run". Kept the leading comment mentioning `flask run` for historical context (explaining *why* we switched).
##########
.github/workflows/bashlib.sh:
##########
@@ -224,7 +238,9 @@ playwright-run() {
local APP_ROOT=$1
local TEST_PATH=$2
- # Start Flask from the project root (same as Cypress)
+ # Start the Superset backend via gunicorn from the project root.
+ # See cypress-run-all() above for the rationale — the Flask dev server
+ # cannot survive the dashboard import/export tests under load.
cd "$GITHUB_WORKSPACE"
local flasklog="${HOME}/flask-playwright.log"
local port=8081
Review Comment:
Same rename applied in 053adcd6 — `flasklog` → `serverlog`, log group → "gunicorn log for Playwright run". Two distinct log files now (`superset-cypress.log` vs `superset-playwright.log`) so they don't collide if both jobs hit the same runner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] ci(e2e): run backend under gunicorn instead of flask dev server [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #40234:
URL: https://github.com/apache/superset/pull/40234#issuecomment-4484467462
Thanks for the review @Copilot — addressed all three inline comments plus the low-confidence note about the missing EXIT trap on `cypress-run-all` (now installs the same trap as `playwright-run`, so gunicorn is cleaned up and the log is emitted even when the runner fails under `set -e`). Pushed as 053adcd6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] ci(e2e): run backend under gunicorn instead of flask dev server [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40234:
URL: https://github.com/apache/superset/pull/40234#issuecomment-4503275208
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] ci(e2e): run backend under gunicorn instead of flask dev server [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #40234:
URL: https://github.com/apache/superset/pull/40234#issuecomment-4484394386
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/40234?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 64.16%. Comparing base ([`4ceefb7`](https://app.codecov.io/gh/apache/superset/commit/4ceefb7e401013b82e0f342a7d2ce96d20c8f92e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a43f3a4`](https://app.codecov.io/gh/apache/superset/commit/a43f3a421b38e9566c19deeca98f7479d28653ed?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #40234 +/- ##
=======================================
Coverage 64.16% 64.16%
=======================================
Files 2591 2591
Lines 138283 138283
Branches 32083 32083
=======================================
Hits 88730 88730
Misses 48023 48023
Partials 1530 1530
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/40234/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/40234/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.04% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/40234?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] ci(e2e): run backend under gunicorn instead of flask dev server [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40234:
URL: https://github.com/apache/superset/pull/40234#issuecomment-4484310093
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] ci(e2e): run backend under gunicorn instead of flask dev server [superset]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #40234:
URL: https://github.com/apache/superset/pull/40234#discussion_r3263648580
##########
.github/workflows/bashlib.sh:
##########
@@ -187,7 +190,18 @@ cypress-run-all() {
fi
export CYPRESS_BASE_URL
- nohup flask run --no-debugger -p $port >"$flasklog" 2>&1 </dev/null &
+ nohup gunicorn \
+ --bind "127.0.0.1:$port" \
+ --workers 4 \
+ --worker-class gthread \
+ --threads 20 \
+ --timeout 120 \
+ --max-requests 500 \
+ --max-requests-jitter 50 \
+ --access-logfile - \
+ --error-logfile - \
+ "superset.app:create_app()" \
+ >"$flasklog" 2>&1 </dev/null &
local flaskProcessId=$!
Review Comment:
cypress-run-all() starts gunicorn in the background but never waits for it to become healthy before launching Cypress. Unlike playwright-run() (which polls `/health`), this can race and produce intermittent connection errors if the first spec starts before the server is listening. Add a short readiness loop (curl `/health` with a timeout) and fail fast with the startup log if the backend never comes up.
##########
.github/workflows/bashlib.sh:
##########
@@ -175,9 +175,12 @@ cypress-run-all() {
local APP_ROOT=$2
cd "$GITHUB_WORKSPACE/superset-frontend/cypress-base"
- # Start Flask and run it in background
- # --no-debugger means disable the interactive debugger on the 500 page
- # so errors can print to stderr.
+ # Start the Superset backend via gunicorn (not `flask run`). The Flask
+ # development server is single-threaded and has no crash-recovery, so
+ # heavy tests (dashboard import/export, SQL Lab) can knock it offline
+ # for the rest of the run — surfacing as `ECONNREFUSED` / `socket hang up`
+ # / `Missing CSRF token` cascades. Gunicorn gives us multiple workers,
+ # a request timeout, and worker-recycling under load.
local flasklog="${HOME}/flask.log"
local port=8081
Review Comment:
Several identifiers/messages still refer to Flask even though the backend is now started via gunicorn (e.g., `flasklog`, `flaskProcessId`, and the later "Flask log" group label). Renaming these to backend/gunicorn-oriented names will reduce confusion when debugging CI failures.
##########
.github/workflows/bashlib.sh:
##########
@@ -224,7 +238,9 @@ playwright-run() {
local APP_ROOT=$1
local TEST_PATH=$2
- # Start Flask from the project root (same as Cypress)
+ # Start the Superset backend via gunicorn from the project root.
+ # See cypress-run-all() above for the rationale — the Flask dev server
+ # cannot survive the dashboard import/export tests under load.
cd "$GITHUB_WORKSPACE"
local flasklog="${HOME}/flask-playwright.log"
local port=8081
Review Comment:
playwright-run() also continues to use `flasklog`/"Flask log" naming even though the process is gunicorn. Consider renaming the log variable and group titles so logs are easier to interpret during CI triage (especially since there are now two different log files).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] ci(e2e): run backend under gunicorn instead of flask dev server [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #40234:
URL: https://github.com/apache/superset/pull/40234#discussion_r3279006290
##########
.github/workflows/bashlib.sh:
##########
@@ -187,8 +190,48 @@ cypress-run-all() {
fi
export CYPRESS_BASE_URL
- nohup flask run --no-debugger -p $port >"$flasklog" 2>&1 </dev/null &
- local flaskProcessId=$!
+ nohup gunicorn \
Review Comment:
Good call — pushed a commit aligning to that. Now using `--workers 1 --worker-class gthread --threads 20` (matching the entrypoint defaults). The remaining divergences are intentional for E2E load and called out in a comment block above the invocation:
- `--timeout 120` — heavy dashboard import/export specs blow past the 60s default
- `--max-requests 500 --max-requests-jitter 50` — recycle the worker under sustained test load
- `superset.app:create_app()` — explicit factory so we don't rely on `FLASK_APP` being exported in the test env
Bonus: dropping from 4 workers to 1 also looks to fix the two SQL Lab → Explore playwright failures that were caused by cross-worker timing races. Thanks for catching this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] ci(e2e): run backend under gunicorn instead of flask dev server [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #40234:
URL: https://github.com/apache/superset/pull/40234#issuecomment-4484309571
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] ci(e2e): run backend under gunicorn instead of flask dev server [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40234:
URL: https://github.com/apache/superset/pull/40234#issuecomment-4521376188
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] ci(e2e): run backend under gunicorn instead of flask dev server [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #40234:
URL: https://github.com/apache/superset/pull/40234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] ci(e2e): run backend under gunicorn instead of flask dev server [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on code in PR #40234:
URL: https://github.com/apache/superset/pull/40234#discussion_r3278161224
##########
.github/workflows/bashlib.sh:
##########
@@ -187,8 +190,48 @@ cypress-run-all() {
fi
export CYPRESS_BASE_URL
- nohup flask run --no-debugger -p $port >"$flasklog" 2>&1 </dev/null &
- local flaskProcessId=$!
+ nohup gunicorn \
Review Comment:
Should we use Gunicorn's args similar to the ones applied in `docker/entrypoints/run-server.sh`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] ci(e2e): run backend under gunicorn instead of flask dev server [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #40234:
URL: https://github.com/apache/superset/pull/40234#issuecomment-4505291231
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 8838dbe6d450fd77448a0be04cbc87dcd09a0cc1 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a0ea13cd3ec2d0008e6a6c2 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-40234--superset-docs-preview.netlify.app](https://deploy-preview-40234--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcpRCoAgDADQu-y7yBIkukHHWHOUYDpmERLdPf_ex3tBNJ9ywQLQwaaY6GimMEjE-mjYj6unKsql9PudAmVNbXqWmOvq23VoGEdL3jJN3hgzs0NHE3w_) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-40234--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] ci(e2e): run backend under gunicorn instead of flask dev server [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40234:
URL: https://github.com/apache/superset/pull/40234#issuecomment-4484300332
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org