You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Lukasz Lenart <lu...@apache.org> on 2014/02/18 15:10:27 UTC
Code review
Hi,
I have created PR via GitHub so everybody can simple review the
changes. It's far easier to use GH for that than use Review Board or
Fisheye. For now I think it is preferred way if you want to get
others' opinion about your changes.
https://github.com/apache/struts/pull/1
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [struts-dev] Code review
Posted by Lukasz Lenart <lu...@apache.org>.
2014-02-18 16:24 GMT+01:00 Jason Pyeron <jp...@pdinc.us>:
> Is the intention to have replies to the github messages on this list be added to
> the pull request comments?
Yes, both ways.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
RE: [struts-dev] Code review
Posted by Jason Pyeron <jp...@pdinc.us>.
> -----Original Message-----
> From: Lukasz Lenart
> Sent: Tuesday, February 18, 2014 9:10
>
> Hi,
>
> I have created PR via GitHub so everybody can simple review
> the changes. It's far easier to use GH for that than use
> Review Board or Fisheye. For now I think it is preferred way
> if you want to get others' opinion about your changes.
>
> https://github.com/apache/struts/pull/1
>
I do like the format.
Is the intention to have replies to the github messages on this list be added to
the pull request comments?
--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
- -
- Jason Pyeron PD Inc. http://www.pdinc.us -
- Principal Consultant 10 West 24th Street #100 -
- +1 (443) 269-1555 x333 Baltimore, Maryland 21218 -
- -
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
This message is copyright PD Inc, subject to license 20080407P00.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org