[GitHub] [tinkerpop] jorgebay commented on a change in pull request #1369: TINKERPOP-2472 Decouple the driver from the IO format

[GitBox <gi...@apache.org>]

jorgebay commented on a change in pull request #1369:
URL: https://github.com/apache/tinkerpop/pull/1369#discussion_r546612915



##########
File path: gremlin-dotnet/src/Gremlin.Net/Driver/GremlinClient.cs
##########
@@ -35,43 +35,126 @@ namespace Gremlin.Net.Driver
     /// </summary>
     public class GremlinClient : IGremlinClient
     {
-        /// <summary>
-        /// Defines the default mime type to use.
-        /// </summary>
-        public const string DefaultMimeType = "application/vnd.gremlin-v3.0+json";
+        private readonly ConnectionPool _connectionPool;
 
         /// <summary>
-        /// The GraphSON2 mime type to use.
+        ///     Initializes a new instance of the <see cref="GremlinClient" /> class for the specified Gremlin Server.
         /// </summary>
-        public const string GraphSON2MimeType = "application/vnd.gremlin-v2.0+json";
+        /// <param name="gremlinServer">The <see cref="GremlinServer" /> the requests should be sent to.</param>
+        /// <param name="graphSONReader">A <see cref="GraphSONReader" /> instance to read received GraphSON data.</param>
+        /// <param name="graphSONWriter">a <see cref="GraphSONWriter" /> instance to write GraphSON data.</param>
+        /// <param name="connectionPoolSettings">The <see cref="ConnectionPoolSettings" /> for the connection pool.</param>
+        /// <param name="webSocketConfiguration">
+        ///     A delegate that will be invoked with the <see cref="ClientWebSocketOptions" />
+        ///     object used to configure WebSocket connections.
+        /// </param>
+        /// <param name="sessionId">The session Id if Gremlin Client in session mode, defaults to null as session-less Client.</param>
+        [Obsolete("This constructor is obsolete. Use the constructor that takes a IMessageSerializer instead.")]

Review comment:
       Good idea to mark it as deprecated and documenting the upgrade path.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org