You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@freemarker.apache.org by Daniel Dekany <dd...@apache.org> on 2024/05/08 23:36:31 UTC
[VOTE] Release Apache FreeMarker 2.3.33
Hi all,
Please vote on releasing FreeMarker 2.3.33!
Release Notes:
https://freemarker.apache.org/builds/2.3.33-voting/_html/versions_2_3_33.html
Before proceed, you should know that FreeMarker 2.3.x, for a long
time, always releases a normal and a "gae" variant on the same time,
which are technically two independent source trees (Git branches). The
"gae" variant contains a few small modification in the Java source
code to be Google App Engine compliant, and has freemarker-gae as the
Maven artifact name. Otherwise the normal and the "gae" branches are
identical. Hence they will be voted on together.
The commits to be voted upon are:
- Normal (non-gae) variant:
https://github.com/apache/freemarker/commit/46c927cdd9409405cb006c0f8ad6d9d41c167878
Commit hash: 46c927cdd9409405cb006c0f8ad6d9d41c167878
- "gae" variant:
https://github.com/apache/freemarker/commit/cf3da59be93ac05de5ceb556c94499b296553509
Commit hash: cf3da59be93ac05de5ceb556c94499b296553509
The artifacts to be voted upon are located here:
https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.33/source/
where the source release artifacts are:
- Normal (non-gae) variant:
apache-freemarker-src-2.3.33.tar.gz
- "gae" variant:
apache-freemarker-gae-src-2.3.33.tar.gz
See the "Building FreeMarker" section of the README.md inside them for
build instructions!
As described there:
- You need to add the gradle-wrapper.jar manually
- You need multiple JDK versions installed, on locations where Gradle
will find them
- You may need freemarker.allowUnsignedReleaseBuild=true for building
everything (not just the jar)
The release artifacts are signed with the following key:
https://people.apache.org/keys/committer/ddekany.asc
For convenience, we also provide binaries, which also need to be checked:
https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.33/binaries/
and Maven artifacts in the ASF Staging Repository:
https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.33/
Please try out the package and vote!
The vote is open for a minimum of 72 hours or until the necessary number of
votes (3 binding +1s) is reached.
[ ] +1 Release this package as Apache FreeMarker 2.3.33
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...
Please add "(binding)" if your vote is binding.
--
Thanks,
Daniel Dekany
Re: [VOTE] Release Apache FreeMarker 2.3.33
Posted by Daniel Dekany <da...@gmail.com>.
Consider the other two enum values, the
..._UNLESS_BEAN_PROPERTY_READ_METHOD ones. They both want to create a
(fake) property called "isActive". But instead, because it's also a
real Java Bean property read method, instead it's exposed as a pure
method. Hence the "unless" part. In the case of the third enum,
"METHOD_ONLY", it wants to expose "isActive" as a method. But then,
because it's also a real Java Bean property read method, instead it's
exposed as a method. Which is the same thing, so, nothing has changed,
the policy wanted the same outcome.
On Sat, May 18, 2024 at 8:02 PM Simon Hartley
<sc...@yahoo.co.uk.invalid> wrote:
>
> About ZeroArgumentNonVoidMethodPolicy.METHOD_ONLY.
>
> If I set:
> recordZeroArgumentNonVoidMethodPolicy=freemarker.ext.beans.ZeroArgumentNonVoidMethodPolicy.METHOD_ONLY
>
> and add this method to a record:
>
> public boolean isActive() {
> return false;
> }
>
> Since it's a bean property read method, I can successfully call:
> ${myRecord.active?c}
>
>
> Since bean property read methods take zero arguments and have non-void returns,
> I was wondering why ZeroArgumentNonVoidMethodPolicy.METHOD_ONLY got spared the "_UNLESS_BEAN_PROPERTY_READ_METHOD" treatment.
>
>
> Cheers,
> Simon
>
>
>
>
>
>
> On Saturday 18 May 2024 at 17:20:38 BST, Daniel Dekany <dd...@apache.org> wrote:
>
>
>
>
>
> Anyone else plans to try this before release? (Because if not, there's
> no need to wait more.)
--
Best regards,
Daniel Dekany
Re: [VOTE] Release Apache FreeMarker 2.3.33
Posted by Simon Hartley <sc...@yahoo.co.uk.INVALID>.
About ZeroArgumentNonVoidMethodPolicy.METHOD_ONLY.
If I set:
recordZeroArgumentNonVoidMethodPolicy=freemarker.ext.beans.ZeroArgumentNonVoidMethodPolicy.METHOD_ONLY
and add this method to a record:
public boolean isActive() {
return false;
}
Since it's a bean property read method, I can successfully call:
${myRecord.active?c}
Since bean property read methods take zero arguments and have non-void returns,
I was wondering why ZeroArgumentNonVoidMethodPolicy.METHOD_ONLY got spared the "_UNLESS_BEAN_PROPERTY_READ_METHOD" treatment.
Cheers,
Simon
On Saturday 18 May 2024 at 17:20:38 BST, Daniel Dekany <dd...@apache.org> wrote:
Anyone else plans to try this before release? (Because if not, there's
no need to wait more.)
Re: [VOTE] Release Apache FreeMarker 2.3.33
Posted by Daniel Dekany <dd...@apache.org>.
Anyone else plans to try this before release? (Because if not, there's
no need to wait more.)
On Thu, May 9, 2024 at 1:36 AM Daniel Dekany <dd...@apache.org> wrote:
>
> Hi all,
>
> Please vote on releasing FreeMarker 2.3.33!
>
> Release Notes:
> https://freemarker.apache.org/builds/2.3.33-voting/_html/versions_2_3_33.html
>
> Before proceed, you should know that FreeMarker 2.3.x, for a long
> time, always releases a normal and a "gae" variant on the same time,
> which are technically two independent source trees (Git branches). The
> "gae" variant contains a few small modification in the Java source
> code to be Google App Engine compliant, and has freemarker-gae as the
> Maven artifact name. Otherwise the normal and the "gae" branches are
> identical. Hence they will be voted on together.
>
> The commits to be voted upon are:
> - Normal (non-gae) variant:
> https://github.com/apache/freemarker/commit/46c927cdd9409405cb006c0f8ad6d9d41c167878
> Commit hash: 46c927cdd9409405cb006c0f8ad6d9d41c167878
> - "gae" variant:
> https://github.com/apache/freemarker/commit/cf3da59be93ac05de5ceb556c94499b296553509
> Commit hash: cf3da59be93ac05de5ceb556c94499b296553509
>
> The artifacts to be voted upon are located here:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.33/source/
> where the source release artifacts are:
> - Normal (non-gae) variant:
> apache-freemarker-src-2.3.33.tar.gz
> - "gae" variant:
> apache-freemarker-gae-src-2.3.33.tar.gz
>
> See the "Building FreeMarker" section of the README.md inside them for
> build instructions!
> As described there:
> - You need to add the gradle-wrapper.jar manually
> - You need multiple JDK versions installed, on locations where Gradle
> will find them
> - You may need freemarker.allowUnsignedReleaseBuild=true for building
> everything (not just the jar)
>
> The release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/ddekany.asc
>
> For convenience, we also provide binaries, which also need to be checked:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.33/binaries/
> and Maven artifacts in the ASF Staging Repository:
> https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.33/
>
> Please try out the package and vote!
>
> The vote is open for a minimum of 72 hours or until the necessary number of
> votes (3 binding +1s) is reached.
>
> [ ] +1 Release this package as Apache FreeMarker 2.3.33
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
> Please add "(binding)" if your vote is binding.
>
> --
> Thanks,
> Daniel Dekany
Re: [VOTE] Release Apache FreeMarker 2.3.33
Posted by Jacques Le Roux <ja...@les7arts.com>.
+1
Thanks Daniel !
Le 09/05/2024 à 01:36, Daniel Dekany a écrit :
> Hi all,
>
> Please vote on releasing FreeMarker 2.3.33!
>
> Release Notes:
> https://freemarker.apache.org/builds/2.3.33-voting/_html/versions_2_3_33.html
>
> Before proceed, you should know that FreeMarker 2.3.x, for a long
> time, always releases a normal and a "gae" variant on the same time,
> which are technically two independent source trees (Git branches). The
> "gae" variant contains a few small modification in the Java source
> code to be Google App Engine compliant, and has freemarker-gae as the
> Maven artifact name. Otherwise the normal and the "gae" branches are
> identical. Hence they will be voted on together.
>
> The commits to be voted upon are:
> - Normal (non-gae) variant:
> https://github.com/apache/freemarker/commit/46c927cdd9409405cb006c0f8ad6d9d41c167878
> Commit hash: 46c927cdd9409405cb006c0f8ad6d9d41c167878
> - "gae" variant:
> https://github.com/apache/freemarker/commit/cf3da59be93ac05de5ceb556c94499b296553509
> Commit hash: cf3da59be93ac05de5ceb556c94499b296553509
>
> The artifacts to be voted upon are located here:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.33/source/
> where the source release artifacts are:
> - Normal (non-gae) variant:
> apache-freemarker-src-2.3.33.tar.gz
> - "gae" variant:
> apache-freemarker-gae-src-2.3.33.tar.gz
>
> See the "Building FreeMarker" section of the README.md inside them for
> build instructions!
> As described there:
> - You need to add the gradle-wrapper.jar manually
> - You need multiple JDK versions installed, on locations where Gradle
> will find them
> - You may need freemarker.allowUnsignedReleaseBuild=true for building
> everything (not just the jar)
>
> The release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/ddekany.asc
>
> For convenience, we also provide binaries, which also need to be checked:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.33/binaries/
> and Maven artifacts in the ASF Staging Repository:
> https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.33/
>
> Please try out the package and vote!
>
> The vote is open for a minimum of 72 hours or until the necessary number of
> votes (3 binding +1s) is reached.
>
> [ ] +1 Release this package as Apache FreeMarker 2.3.33
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
> Please add "(binding)" if your vote is binding.
>
> --
> Thanks,
> Daniel Dekany
Re: [VOTE] Release Apache FreeMarker 2.3.33
Posted by Woonsan Ko <wo...@apache.org>.
[X] +1 Release this package as Apache FreeMarker 2.3.33
(binding)
Signatures verified, release notes looking good, and builds successful
with jar, check, javadoc and manualOffline in my env (gradle 8.6 on
Windows 11).
Regards,
Woonsan
On Thu, May 9, 2024 at 8:36 AM Daniel Dekany <dd...@apache.org> wrote:
>
> Hi all,
>
> Please vote on releasing FreeMarker 2.3.33!
>
> Release Notes:
> https://freemarker.apache.org/builds/2.3.33-voting/_html/versions_2_3_33.html
>
> Before proceed, you should know that FreeMarker 2.3.x, for a long
> time, always releases a normal and a "gae" variant on the same time,
> which are technically two independent source trees (Git branches). The
> "gae" variant contains a few small modification in the Java source
> code to be Google App Engine compliant, and has freemarker-gae as the
> Maven artifact name. Otherwise the normal and the "gae" branches are
> identical. Hence they will be voted on together.
>
> The commits to be voted upon are:
> - Normal (non-gae) variant:
> https://github.com/apache/freemarker/commit/46c927cdd9409405cb006c0f8ad6d9d41c167878
> Commit hash: 46c927cdd9409405cb006c0f8ad6d9d41c167878
> - "gae" variant:
> https://github.com/apache/freemarker/commit/cf3da59be93ac05de5ceb556c94499b296553509
> Commit hash: cf3da59be93ac05de5ceb556c94499b296553509
>
> The artifacts to be voted upon are located here:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.33/source/
> where the source release artifacts are:
> - Normal (non-gae) variant:
> apache-freemarker-src-2.3.33.tar.gz
> - "gae" variant:
> apache-freemarker-gae-src-2.3.33.tar.gz
>
> See the "Building FreeMarker" section of the README.md inside them for
> build instructions!
> As described there:
> - You need to add the gradle-wrapper.jar manually
> - You need multiple JDK versions installed, on locations where Gradle
> will find them
> - You may need freemarker.allowUnsignedReleaseBuild=true for building
> everything (not just the jar)
>
> The release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/ddekany.asc
>
> For convenience, we also provide binaries, which also need to be checked:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.33/binaries/
> and Maven artifacts in the ASF Staging Repository:
> https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.33/
>
> Please try out the package and vote!
>
> The vote is open for a minimum of 72 hours or until the necessary number of
> votes (3 binding +1s) is reached.
>
> [ ] +1 Release this package as Apache FreeMarker 2.3.33
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
> Please add "(binding)" if your vote is binding.
>
> --
> Thanks,
> Daniel Dekany
Re: [VOTE] Release Apache FreeMarker 2.3.33
Posted by Christoph Rueger <ch...@gmail.com>.
+1
we ran it successfully through all of our test suites + some manual testing.
Am Do., 9. Mai 2024 um 01:36 Uhr schrieb Daniel Dekany <dd...@apache.org>:
> Hi all,
>
> Please vote on releasing FreeMarker 2.3.33!
>
> Release Notes:
>
> https://freemarker.apache.org/builds/2.3.33-voting/_html/versions_2_3_33.html
>
> Before proceed, you should know that FreeMarker 2.3.x, for a long
> time, always releases a normal and a "gae" variant on the same time,
> which are technically two independent source trees (Git branches). The
> "gae" variant contains a few small modification in the Java source
> code to be Google App Engine compliant, and has freemarker-gae as the
> Maven artifact name. Otherwise the normal and the "gae" branches are
> identical. Hence they will be voted on together.
>
> The commits to be voted upon are:
> - Normal (non-gae) variant:
>
> https://github.com/apache/freemarker/commit/46c927cdd9409405cb006c0f8ad6d9d41c167878
> Commit hash: 46c927cdd9409405cb006c0f8ad6d9d41c167878
> - "gae" variant:
>
> https://github.com/apache/freemarker/commit/cf3da59be93ac05de5ceb556c94499b296553509
> Commit hash: cf3da59be93ac05de5ceb556c94499b296553509
>
> The artifacts to be voted upon are located here:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.33/source/
> where the source release artifacts are:
> - Normal (non-gae) variant:
> apache-freemarker-src-2.3.33.tar.gz
> - "gae" variant:
> apache-freemarker-gae-src-2.3.33.tar.gz
>
> See the "Building FreeMarker" section of the README.md inside them for
> build instructions!
> As described there:
> - You need to add the gradle-wrapper.jar manually
> - You need multiple JDK versions installed, on locations where Gradle
> will find them
> - You may need freemarker.allowUnsignedReleaseBuild=true for building
> everything (not just the jar)
>
> The release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/ddekany.asc
>
> For convenience, we also provide binaries, which also need to be checked:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.33/binaries/
> and Maven artifacts in the ASF Staging Repository:
>
> https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.33/
>
> Please try out the package and vote!
>
> The vote is open for a minimum of 72 hours or until the necessary number of
> votes (3 binding +1s) is reached.
>
> [ ] +1 Release this package as Apache FreeMarker 2.3.33
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
> Please add "(binding)" if your vote is binding.
>
> --
> Thanks,
> Daniel Dekany
>
Re: [VOTE] Release Apache FreeMarker 2.3.33
Posted by Daniel Dekany <dd...@apache.org>.
Well, I will add my +1 in the coming days (assuming I won't find
anything bad somehow), so we will be able to release. But again, will
anyone else try this? Because then I will wait for that.
On Thu, May 9, 2024 at 1:36 AM Daniel Dekany <dd...@apache.org> wrote:
>
> Hi all,
>
> Please vote on releasing FreeMarker 2.3.33!
>
> Release Notes:
> https://freemarker.apache.org/builds/2.3.33-voting/_html/versions_2_3_33.html
>
> Before proceed, you should know that FreeMarker 2.3.x, for a long
> time, always releases a normal and a "gae" variant on the same time,
> which are technically two independent source trees (Git branches). The
> "gae" variant contains a few small modification in the Java source
> code to be Google App Engine compliant, and has freemarker-gae as the
> Maven artifact name. Otherwise the normal and the "gae" branches are
> identical. Hence they will be voted on together.
>
> The commits to be voted upon are:
> - Normal (non-gae) variant:
> https://github.com/apache/freemarker/commit/46c927cdd9409405cb006c0f8ad6d9d41c167878
> Commit hash: 46c927cdd9409405cb006c0f8ad6d9d41c167878
> - "gae" variant:
> https://github.com/apache/freemarker/commit/cf3da59be93ac05de5ceb556c94499b296553509
> Commit hash: cf3da59be93ac05de5ceb556c94499b296553509
>
> The artifacts to be voted upon are located here:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.33/source/
> where the source release artifacts are:
> - Normal (non-gae) variant:
> apache-freemarker-src-2.3.33.tar.gz
> - "gae" variant:
> apache-freemarker-gae-src-2.3.33.tar.gz
>
> See the "Building FreeMarker" section of the README.md inside them for
> build instructions!
> As described there:
> - You need to add the gradle-wrapper.jar manually
> - You need multiple JDK versions installed, on locations where Gradle
> will find them
> - You may need freemarker.allowUnsignedReleaseBuild=true for building
> everything (not just the jar)
>
> The release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/ddekany.asc
>
> For convenience, we also provide binaries, which also need to be checked:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.33/binaries/
> and Maven artifacts in the ASF Staging Repository:
> https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.33/
>
> Please try out the package and vote!
>
> The vote is open for a minimum of 72 hours or until the necessary number of
> votes (3 binding +1s) is reached.
>
> [ ] +1 Release this package as Apache FreeMarker 2.3.33
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
> Please add "(binding)" if your vote is binding.
>
> --
> Thanks,
> Daniel Dekany
Re: [VOTE] Release Apache FreeMarker 2.3.33
Posted by Daniel Dekany <dd...@apache.org>.
[X] +1 Release this package as Apache FreeMarker 2.3.33
+1 (binding)
On Thu, May 9, 2024 at 1:36 AM Daniel Dekany <dd...@apache.org> wrote:
>
> Hi all,
>
> Please vote on releasing FreeMarker 2.3.33!
>
> Release Notes:
> https://freemarker.apache.org/builds/2.3.33-voting/_html/versions_2_3_33.html
>
> Before proceed, you should know that FreeMarker 2.3.x, for a long
> time, always releases a normal and a "gae" variant on the same time,
> which are technically two independent source trees (Git branches). The
> "gae" variant contains a few small modification in the Java source
> code to be Google App Engine compliant, and has freemarker-gae as the
> Maven artifact name. Otherwise the normal and the "gae" branches are
> identical. Hence they will be voted on together.
>
> The commits to be voted upon are:
> - Normal (non-gae) variant:
> https://github.com/apache/freemarker/commit/46c927cdd9409405cb006c0f8ad6d9d41c167878
> Commit hash: 46c927cdd9409405cb006c0f8ad6d9d41c167878
> - "gae" variant:
> https://github.com/apache/freemarker/commit/cf3da59be93ac05de5ceb556c94499b296553509
> Commit hash: cf3da59be93ac05de5ceb556c94499b296553509
>
> The artifacts to be voted upon are located here:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.33/source/
> where the source release artifacts are:
> - Normal (non-gae) variant:
> apache-freemarker-src-2.3.33.tar.gz
> - "gae" variant:
> apache-freemarker-gae-src-2.3.33.tar.gz
>
> See the "Building FreeMarker" section of the README.md inside them for
> build instructions!
> As described there:
> - You need to add the gradle-wrapper.jar manually
> - You need multiple JDK versions installed, on locations where Gradle
> will find them
> - You may need freemarker.allowUnsignedReleaseBuild=true for building
> everything (not just the jar)
>
> The release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/ddekany.asc
>
> For convenience, we also provide binaries, which also need to be checked:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.33/binaries/
> and Maven artifacts in the ASF Staging Repository:
> https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.33/
>
> Please try out the package and vote!
>
> The vote is open for a minimum of 72 hours or until the necessary number of
> votes (3 binding +1s) is reached.
>
> [ ] +1 Release this package as Apache FreeMarker 2.3.33
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
> Please add "(binding)" if your vote is binding.
>
> --
> Thanks,
> Daniel Dekany