[jira] [Commented] (TINKERPOP-848) Support default attribute values in GraphMLReader

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426511#comment-17426511 ] 

ASF GitHub Bot commented on TINKERPOP-848:
------------------------------------------

amatiushkin opened a new pull request #1485:
URL: https://github.com/apache/tinkerpop/pull/1485


   Draft implementation, which adds support for default values in GraphML ([TINKERPOP-848](https://issues.apache.org/jira/browse/TINKERPOP-848)).
   
   Support feature is incubating, due to following capabilities mentioned in GraphML [specification](http://graphml.graphdrawing.org/specification.html).
   
   
   ```
   <xs:complexType name="default.type" final="#all">
   <xs:annotation>
   <xs:documentation source="http://graphml.graphdrawing.org/" xml:lang="en">
   Complex type for the <default> element. default.type is mixed, that is, data may contain #PCDATA. Content type: extension of data-extension.type which is empty per default.
   </xs:documentation>
   </xs:annotation>
   <xs:complexContent mixed="true">
   <xs:extension base="data-extension.type">
   <xs:attributeGroup ref="default.extra.attrib">
   <xs:annotation>
   <xs:documentation source="http://graphml.graphdrawing.org/" xml:lang="en">
   user defined extra attributes for <default> elements
   </xs:documentation>
   </xs:annotation>
   </xs:attributeGroup>
   </xs:extension>
   </xs:complexContent>
   </xs:complexType>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Support default attribute values in GraphMLReader
> -------------------------------------------------
>
>                 Key: TINKERPOP-848
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-848
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: io
>    Affects Versions: 3.0.2-incubating
>            Reporter: Pavel Klinov
>            Priority: Trivial
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Looking at the code of GraphMLReader I see that it doesn't support default values of attributes, which are allowed by the GraphML spec. This is a bit annoying especially if the input defines default values for attributes which are used for mandatory data, e.g. edge labels. 
> One small example is the sample graph at [1]. "d_e" is the label attribute with a default value. There're <edge .. /> elements w/o body later in the document and reading those will throw a "java.lang.IllegalArgumentException: Label can not be null" exception (if the vendor considers edge labels mandatory).
> I'd personaly squash both keyIdMap and keyTypesMap into a single String -> AttrInfo map, where AttrInfo would contain information about the data attribute name, type, and the default value.
> [1] http://www.eecs.wsu.edu/~yyao/DirectedStudyI/Datasets/AS/sample.graphml



--
This message was sent by Atlassian Jira
(v8.3.4#803005)