You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/07/02 15:12:22 UTC
[GitHub] [camel] edgarc-ciandt opened a new pull request #3969: CAMEL-15233: Fixes Replay Extension to properly save replay id value
edgarc-ciandt opened a new pull request #3969:
URL: https://github.com/apache/camel/pull/3969
[ X ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
[ X ] Each commit in the pull request should have a meaningful subject line and body.
[ X ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
[ X ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ X ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd merged pull request #3969: CAMEL-15233: Fixes Replay Extension to properly save replay id value
Posted by GitBox <gi...@apache.org>.
oscerd merged pull request #3969:
URL: https://github.com/apache/camel/pull/3969
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #3969: CAMEL-15233: Fixes Replay Extension to properly save replay id value
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #3969:
URL: https://github.com/apache/camel/pull/3969#issuecomment-653100446
Ad 2 you can add the ASF license in the top, and then the salesforce license afterwards, just like the old file.
Ad 1 Just fix it manually. There are some checkstyle rules files in the source code that an IDE can use if you install the checkstyle plugin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] edgarc-ciandt commented on pull request #3969: CAMEL-15233: Fixes Replay Extension to properly save replay id value
Posted by GitBox <gi...@apache.org>.
edgarc-ciandt commented on pull request #3969:
URL: https://github.com/apache/camel/pull/3969#issuecomment-653094268
I have two checkstyles issues.
1- One is related to the position of an import. Is there an IDE formatter that I can use for fixing this ?
2- The other is related to the salesforce license comment in the class. Should we keep the license info from salesforce ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org