You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by hequn8128 <gi...@git.apache.org> on 2017/05/09 08:09:11 UTC
[GitHub] flink pull request #3850: [FLINK-6486] [table] (bugfix) Pass RowTypeInfo to ...
GitHub user hequn8128 opened a pull request:
https://github.com/apache/flink/pull/3850
[FLINK-6486] [table] (bugfix) Pass RowTypeInfo to CodeGenerator instead of CRowTypeInfo
For now CodeGenerator only processes Row type, so we should pass RowTypeInfo to CodeGenerator instead of CRowTypeInfo. We can find these bugs in DataStreamGroupAggregate, DataStreamGroupWindowAggregate and DataStreamOverAggregate. These bugs will bring no error to the current flink because no code will make use of the error input type, however we should correct it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hequn8128/flink bugfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3850.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3850
----
commit 75d668eb157e0ed90132976dcc96c167176810d1
Author: Hequn Cheng <ch...@gmail.com>
Date: 2017-05-08T12:55:51Z
[FLINK-6486] [table] (bugfix) Pass RowTypeInfo to CodeGenerator instead of CRowTypeInfo
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3850: [FLINK-6486] [table] (bugfix) Pass RowTypeInfo to CodeGen...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3850
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3850: [FLINK-6486] [table] (bugfix) Pass RowTypeInfo to ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3850
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---