You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commonsrdf.apache.org by Sergio Fernández <wi...@apache.org> on 2015/05/06 22:21:22 UTC
[CANCELLED] [VOTE] Release Apache Commons RDF 0.1.0-incubating RC1
Sorry, I was so focused on all the stuff around the parent, that I missed
that. I was going to vote -1 myself when I started to check the release.
I'll try to find some time tomorrow to prepare a new rc.
On Wed, May 6, 2015 at 7:41 PM, Andy Seaborne <an...@apache.org> wrote:
> Sorry - at the moment:
>
> -1 : Do not release this package because...
>
> No NOTICE file in the source file (or in git).
> No LICENSE, no NOTICE in built jar files.
>
> other than that, it looks good. Thank you for all the effort this has
> taken.
>
> (Should be fixed: I've added the files into git and checked with a local
> build).
>
> Andy
>
> Checking process details and suggestions below:
>
>
> On 06/05/15 12:17, Sergio Fernández wrote:
>
>> Hello
>>
>> I am pleased to be calling this vote for the source release of Apache
>> Commons RDF 0.1.0-incubating, composed by:
>>
>> * commons-rdf-api 0.1-incubating
>> * commons-rdf-simple 0.1.0-incubating
>>
>> A candidate for the Commons RDF 0.1.0 release is available at:
>>
>>
>> https://dist.apache.org/repos/dist/dev/incubator/commonsrdf/0.1.0-incubating/
>>
>> The release candidate is based on the sources tagged as 0.1.0-incubating
>> at:
>>
>> https://git-wip-us.apache.org/repos/asf?p=incubator-commonsrdf.git
>>
>> Release artifacts are signed with the keys available at:
>>
>> https://dist.apache.org/repos/dist/release/incubator/commonsrdf/KEYS
>>
>> A staged Maven repository is available for review at:
>>
>> https://repository.apache.org/content/repositories/orgapachecommons-1094
>>
>> The changelog for this version is available from JIRA:
>>
>>
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316620&version=12332056
>>
>> Please vote on releasing this package as Apache Commons RDF
>> 0.1.0-incubating. The vote is open for at least 72 hours and passes if a
>> majority of at least three +1 Commons RDF PPMC votes are cast.
>>
>> [ ] +1 Release this package
>> [ ] 0 I don't feel strongly about it, but I'm okay with the release
>> [ ] -1 Do not release this package because...
>>
>>
> This is my process for checking - there are a few things that could be
> tidied up for next time.
>
> Check steps:
> + check signatures and checksums
> + check LICENSE and NOTICE
> + build from source release zip or tar.gz
> + check LICENSE and NOTICE in artifacts
> + check the dependencies.
> + do all the tests work?
> + fetch from git, does it contain reproduceable sources?
>
> ----------------------
>
> ** Keys and checksums checked.
> Yes - OK.
>
> ** check LICENSE and NOTICE
> NOTICE missing.
> No LICENSE and NOTICE in artifacts.
>
>
> http://www.apache.org/dev/release.html#notice-required
>
> At a minimum, NOTICE should be:
> http://apache.org/legal/src-headers.html#notice
>
> -------------------------
> Apache Commons RDF
> Copyright 2015 The Apache Software Foundation
>
> This product includes software developed at
> The Apache Software Foundation (http://www.apache.org/).
> -------------------------
>
> I've put the files into git but please check:
>
> new file: NOTICE
> new file: api/src/main/resources/META-INF/LICENSE
> new file: api/src/main/resources/META-INF/NOTICE
> new file: simple/src/main/resources/META-INF/LICENSE
> new file: simple/src/main/resources/META-INF/NOTICE
>
> Dependencies:
>
> The testing dependency JUnit is EPL 1.0:
>
> Do we want a DEPENDENCIES file?
>
> ** Unpack and build from 'src'
> OK
>
> The directory name is
> commons-rdf-parent-0.1.0-incubating/
> not
> apache-commons-rdf-parent-0.1.0-incubating
>
> Does this matter?
>
> "mvn clean verify" from the 'src' file works with a warning:
>
> -- Build comment 1:
>
> [INFO] --- buildnumber-maven-plugin:1.3:create (default) @
> commons-rdf-parent ---
> [INFO] Executing: /bin/sh -c cd
> /home/afs/Desktop/R/commons-rdf-parent-0.1.0-incubating && git rev-parse
> --verify HEAD
> [INFO] Working directory: /home/afs/Desktop/R/commonshttps://
> git-wip-us.apache.org/repos/asf?p=incubator-commonsrdf.git-rdf-parent-0.1.0-incubating
> [INFO] Storing buildNumber: ?????? at timestamp: 1430927945111
> [WARNING] Cannot get the branch information from the git repository:
> Detecting the current branch failed: fatal: Not a git repository (or any
> parent up to mount point /home)
> Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
>
> which is true - but what's git got to do with building from source?
>
> -- Build comment 2:
>
> The 'src' file contains 'pom.xml.releaseBackup' and 'release.properties'.
>
> Is that normal for Commons?
>
> ** dependency check:
>
> [INFO] \- junit:junit:jar:4.12:test
> [INFO] \- org.hamcrest:hamcrest-core:jar:1.3:test
>
> Looks good.
>
> ** Tests
> Pass
>
> ** SCM
>
> git clone'd and built but the VOTE email does not have the commit id, just
> a reference to a git tag.
>
> Git tags can be moved. The commit is
> eba760d0b0eeb0f7e9238ff22da78895eb271f43
>
> We should include the commit id in the VOTE calls.
>
> The clone URL is
>
> https://git-wip-us.apache.org/repos/asf/incubator-commonsrdf.git
>
> not as in the message:
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-commonsrdf.git
>
> ** Other
>
> The PNG is in the api jar file. Is that intentional?
>
--
Sergio Fernández
Partner Technology Manager
Redlink GmbH
m: +43 6602747925
e: sergio.fernandez@redlink.co
w: http://redlink.co
Re: [] [] Release Apache Commons RDF 0.1.0-incubating RC1
Posted by Sergio Fernández <wi...@apache.org>.
On Thu, May 7, 2015 at 10:55 AM, Andy Seaborne <an...@apache.org> wrote:
>
> What remains a mystery to me is why the jars don't have N&L files
> automatically. That's what happens in Jena if there weren't present in
> src/main/resources and I thought was because Jena is using the Apache
> parent (v16). The defaults would be adequate for commons-rdf.
>
I get them under META-INF:
$ unzip -l target/commons-rdf-api-0.1.0-incubating-SNAPSHOT.jar
Archive: target/commons-rdf-api-0.1.0-incubating-SNAPSHOT.jar
Length Date Time Name
--------- ---------- ----- ----
0 2015-05-07 15:07 META-INF/
1314 2015-05-07 15:07 META-INF/MANIFEST.MF
167 2015-05-07 15:07 META-INF/NOTICE
11323 2015-05-07 15:07 META-INF/LICENSE
0 2015-05-07 15:07 org/
0 2015-05-07 15:07 org/apache/
0 2015-05-07 15:07 org/apache/commons/
0 2015-05-07 15:07 org/apache/commons/rdf/
0 2015-05-07 15:07 org/apache/commons/rdf/api/
452 2015-05-07 15:07 org/apache/commons/rdf/api/Literal.class
178 2015-05-07 15:07 org/apache/commons/rdf/api/BlankNodeOrIRI.class
275 2015-05-07 15:07 org/apache/commons/rdf/api/IRI.class
376 2015-05-07 15:07 org/apache/commons/rdf/api/Triple.class
290 2015-05-07 15:07 org/apache/commons/rdf/api/BlankNode.class
170 2015-05-07 15:07 org/apache/commons/rdf/api/RDFTerm.class
2268 2015-05-07 15:07 org/apache/commons/rdf/api/RDFTermFactory.class
2760 2015-05-07 15:07 org/apache/commons/rdf/api/Graph.class
--------- -------
19573 17 files
--
Sergio Fernández
Partner Technology Manager
Redlink GmbH
m: +43 6602747925
e: sergio.fernandez@redlink.co
w: http://redlink.co
Re: [] [] Release Apache Commons RDF 0.1.0-incubating RC1
Posted by Andy Seaborne <an...@apache.org>.
On 07/05/15 07:17, Sergio Fernández wrote:
> OK, now let's go through the concrete issues Andy pointed.
>
> On Wed, May 6, 2015 at 7:41 PM, Andy Seaborne <an...@apache.org> wrote:
>>>
>>> ** check LICENSE and NOTICE
>>> NOTICE missing.
>>> No LICENSE and NOTICE in artifacts.
>>>
>>>
>>> http://www.apache.org/dev/release.html#notice-required
>>>
>>> At a minimum, NOTICE should be:
>>> http://apache.org/legal/src-headers.html#notice
>>>
>>> -------------------------
>>> Apache Commons RDF
>>> Copyright 2015 The Apache Software Foundation
>>>
>>> This product includes software developed at
>>> The Apache Software Foundation (http://www.apache.org/).
>>> -------------------------
>>>
>>> I've put the files into git but please check:
>>>
>>> new file: NOTICE
>>> new file: api/src/main/resources/META-INF/LICENSE
>>> new file: api/src/main/resources/META-INF/NOTICE
>>> new file: simple/src/main/resources/META-INF/LICENSE
>>> new file: simple/src/main/resources/META-INF/NOTICE
>>>
>>
> Perfect, thanks.
>
What remains a mystery to me is why the jars don't have N&L files
automatically. That's what happens in Jena if there weren't present in
src/main/resources and I thought was because Jena is using the Apache
parent (v16). The defaults would be adequate for commons-rdf.
Andy
Re: [CANCELLED] [VOTE] Release Apache Commons RDF 0.1.0-incubating RC1
Posted by Sergio Fernández <wi...@apache.org>.
OK, now let's go through the concrete issues Andy pointed.
On Wed, May 6, 2015 at 7:41 PM, Andy Seaborne <an...@apache.org> wrote:
>>
>> ** check LICENSE and NOTICE
>> NOTICE missing.
>> No LICENSE and NOTICE in artifacts.
>>
>>
>> http://www.apache.org/dev/release.html#notice-required
>>
>> At a minimum, NOTICE should be:
>> http://apache.org/legal/src-headers.html#notice
>>
>> -------------------------
>> Apache Commons RDF
>> Copyright 2015 The Apache Software Foundation
>>
>> This product includes software developed at
>> The Apache Software Foundation (http://www.apache.org/).
>> -------------------------
>>
>> I've put the files into git but please check:
>>
>> new file: NOTICE
>> new file: api/src/main/resources/META-INF/LICENSE
>> new file: api/src/main/resources/META-INF/NOTICE
>> new file: simple/src/main/resources/META-INF/LICENSE
>> new file: simple/src/main/resources/META-INF/NOTICE
>>
>
Perfect, thanks.
> Dependencies:
>>
>> The testing dependency JUnit is EPL 1.0:
>>
>> Do we want a DEPENDENCIES file?
>>
>
Does heart, and in our case it's easy to manage.
> ** Unpack and build from 'src'
>> OK
>>
>> The directory name is
>> commons-rdf-parent-0.1.0-incubating/
>> not
>> apache-commons-rdf-parent-0.1.0-incubating
>>
>> Does this matter?
>>
>
Not really, bu I do not like it. It comes from the maven-assembly-plugin
from either commons-parent or apache-parent. I need to figure out how to
solve it.
"mvn clean verify" from the 'src' file works with a warning:
>>
>> -- Build comment 1:
>>
>> [INFO] --- buildnumber-maven-plugin:1.3:create (default) @
>> commons-rdf-parent ---
>> [INFO] Executing: /bin/sh -c cd
>> /home/afs/Desktop/R/commons-rdf-parent-0.1.0-incubating && git rev-parse
>> --verify HEAD
>> [INFO] Working directory: /home/afs/Desktop/R/commonshttps://
>> git-wip-us.apache.org/repos/asf?p=incubator-commonsrdf.git-rdf-parent-0.1.0-incubating
>> [INFO] Storing buildNumber: ?????? at timestamp: 1430927945111
>> [WARNING] Cannot get the branch information from the git repository:
>> Detecting the current branch failed: fatal: Not a git repository (or any
>> parent up to mount point /home)
>> Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
>>
>> which is true - but what's git got to do with building from source?
>>
>
Probably from the pom.xml... I'll take a look.
> -- Build comment 2:
>>
>> The 'src' file contains 'pom.xml.releaseBackup' and 'release.properties'.
>>
>> Is that normal for Commons?
>>
>
My error. Those files are generated by the maven-release-plugin to manage
the release cycle. I'll try to short it out in the assembly to avoid the
inclusion of such 'garbage'.
> ** SCM
>>
>> git clone'd and built but the VOTE email does not have the commit id,
>> just a reference to a git tag.
>>
>> Git tags can be moved. The commit is
>> eba760d0b0eeb0f7e9238ff22da78895eb271f43
>>
>> We should include the commit id in the VOTE calls.
>>
>
Absolutely. I forgot it, sorry.
> The clone URL is
>>
>> https://git-wip-us.apache.org/repos/asf/incubator-commonsrdf.git
>>
>> not as in the message:
>>
>> https://git-wip-us.apache.org/repos/asf?p=incubator-commonsrdf.git
>
>
Yes, again, my mistake.
** Other
>>
>> The PNG is in the api jar file. Is that intentional?
>
>
I think I'll try to remove all those asset used in the web site from the
binary artifacts.
Later I'll resume this and try a new rc.
Thanks for all the comments.
Cheers,
--
Sergio Fernández
Partner Technology Manager
Redlink GmbH
m: +43 6602747925
e: sergio.fernandez@redlink.co
w: http://redlink.co