You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/03/19 15:56:03 UTC

[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #742: [#133] feat(netty): Add Encoder and Decoder.

codecov-commenter commented on PR #742:
URL: https://github.com/apache/incubator-uniffle/pull/742#issuecomment-1475302259

   ## [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/742?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#742](https://codecov.io/gh/apache/incubator-uniffle/pull/742?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2dca710) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/d60d675d38c833b99b012a1f4c726a012ce93463?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d60d675) will **increase** coverage by `3.49%`.
   > The diff coverage is `66.90%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #742      +/-   ##
   ============================================
   + Coverage     60.63%   64.13%   +3.49%     
   + Complexity     1893     1806      -87     
   ============================================
     Files           238      216      -22     
     Lines         13000    10037    -2963     
     Branches       1090     1002      -88     
   ============================================
   - Hits           7883     6437    -1446     
   + Misses         4679     3227    -1452     
   + Partials        438      373      -65     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-uniffle/pull/742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...che/uniffle/common/netty/protocol/RpcResponse.java](https://codecov.io/gh/apache/incubator-uniffle/pull/742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9uZXR0eS9wcm90b2NvbC9ScGNSZXNwb25zZS5qYXZh) | `65.51% <12.50%> (-20.20%)` | :arrow_down: |
   | [...va/org/apache/uniffle/common/ShuffleBlockInfo.java](https://codecov.io/gh/apache/incubator-uniffle/pull/742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9TaHVmZmxlQmxvY2tJbmZvLmphdmE=) | `82.97% <22.22%> (-4.21%)` | :arrow_down: |
   | [...he/uniffle/common/netty/TransportFrameDecoder.java](https://codecov.io/gh/apache/incubator-uniffle/pull/742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9uZXR0eS9UcmFuc3BvcnRGcmFtZURlY29kZXIuamF2YQ==) | `50.60% <50.60%> (ø)` | |
   | [.../apache/uniffle/common/netty/protocol/Message.java](https://codecov.io/gh/apache/incubator-uniffle/pull/742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9uZXR0eS9wcm90b2NvbC9NZXNzYWdlLmphdmE=) | `52.45% <54.76%> (+2.45%)` | :arrow_up: |
   | [...rg/apache/uniffle/common/netty/MessageEncoder.java](https://codecov.io/gh/apache/incubator-uniffle/pull/742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9uZXR0eS9NZXNzYWdlRW5jb2Rlci5qYXZh) | `78.57% <78.57%> (ø)` | |
   | [.../common/netty/protocol/SendShuffleDataRequest.java](https://codecov.io/gh/apache/incubator-uniffle/pull/742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9uZXR0eS9wcm90b2NvbC9TZW5kU2h1ZmZsZURhdGFSZXF1ZXN0LmphdmE=) | `80.95% <80.95%> (ø)` | |
   | [...a/org/apache/uniffle/common/util/ByteBufUtils.java](https://codecov.io/gh/apache/incubator-uniffle/pull/742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi91dGlsL0J5dGVCdWZVdGlscy5qYXZh) | `89.65% <81.81%> (-4.79%)` | :arrow_down: |
   | [...apache/uniffle/common/netty/protocol/Decoders.java](https://codecov.io/gh/apache/incubator-uniffle/pull/742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9uZXR0eS9wcm90b2NvbC9EZWNvZGVycy5qYXZh) | `95.23% <95.23%> (ø)` | |
   | [...apache/uniffle/common/netty/protocol/Encoders.java](https://codecov.io/gh/apache/incubator-uniffle/pull/742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9uZXR0eS9wcm90b2NvbC9FbmNvZGVycy5qYXZh) | `96.42% <96.42%> (ø)` | |
   | [...pache/spark/shuffle/writer/WriteBufferManager.java](https://codecov.io/gh/apache/incubator-uniffle/pull/742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS93cml0ZXIvV3JpdGVCdWZmZXJNYW5hZ2VyLmphdmE=) | `83.21% <100.00%> (+0.11%)` | :arrow_up: |
   
   ... and [28 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-uniffle/pull/742/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org