[GitHub] [tomcat] markt-asf commented on a change in pull request #228: Correct header too large status to 414

[GitBox <gi...@apache.org>]

markt-asf commented on a change in pull request #228: Correct header too large status to 414
URL: https://github.com/apache/tomcat/pull/228#discussion_r353034038
 
 

 ##########
 File path: java/org/apache/coyote/http11/Http11InputBuffer.java
 ##########
 @@ -723,7 +723,7 @@ private boolean fill(boolean block) throws IOException {
                     // Avoid unknown protocol triggering an additional error
                     request.protocol().setString(Constants.HTTP_11);
                 }
-                throw new IllegalArgumentException(sm.getString("iib.requestheadertoolarge.error"));
+                throw new HeadersTooLargeException(sm.getString("iib.requestheadertoolarge.error"));
             }
 
 Review comment:
   This will trigger both if the request line is too long (OK) and if the HTTP headers are too big (bad).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org