[GitHub] [incubator-superset] mistercrunch commented on issue #9444: Implement dttm column configuration through db extra config

[GitBox <gi...@apache.org>]

mistercrunch commented on issue #9444:
URL: https://github.com/apache/incubator-superset/pull/9444#issuecomment-616884502


   Generally LGTM
   
   I think personally I prefer dynamic configuration hooks, where you'd define a function that receives a live table object upon insert and/or modify, and mutate it with whatever business/semantical logic make sense to your org, keeping all the logic on your side.
   
   Intricate static configuration like the one defined here is hard to discover, often requires to read code to understand what it does / can do, and often has shortcomings / requires code change to the core package to get things done.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org