[GitHub] [apisix] soulbird commented on a diff in pull request #7554: feat(key-auth): support get key from variable combination

[GitBox <gi...@apache.org>]

soulbird commented on code in PR #7554:
URL: https://github.com/apache/apisix/pull/7554#discussion_r931863655


##########
t/plugin/key-auth.t:
##########
@@ -585,3 +585,84 @@ GET /hello?auth=auth-one
 auth: auth-one
 --- no_error_log
 [error]
+
+
+
+=== TEST 26: add consumer with plugin and username
+--- config
+    location /t {
+        content_by_lua_block {
+            local t = require("lib.test_admin").test
+            local code, body = t('/apisix/admin/consumers',
+                ngx.HTTP_PUT,
+                [[{
+                    "username": "bob",
+                    "plugins": {
+                        "key-auth": {
+                            "key": "12345:abc"
+                        }
+                    }
+                }]]
+                )
+
+            if code >= 300 then
+                ngx.status = code
+            end
+            ngx.say(body)
+        }
+    }
+--- request
+GET /t
+--- response_body
+passed
+--- no_error_log
+[error]
+
+
+
+=== TEST 27: add key-auth plugin with var_combination
+--- config
+    location /t {
+        content_by_lua_block {
+            local t = require("lib.test_admin").test
+            local code, body = t('/apisix/admin/routes/1',
+                ngx.HTTP_PUT,
+                [[{
+                    "plugins": {
+                        "key-auth": {
+                            "var_combination": "${http_client_id}:${http_client_secret}"

Review Comment:
   The documentation is just an example of what can be configured, it is not the same as the test case, and the documentation and the test case are not the same for the users. There is no right or wrong here. But I can unify them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org