You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2019/11/13 20:24:25 UTC
[GitHub] [bookkeeper] reddycharan opened a new pull request #2206: Remove lock from URManager’s state only if lock znode deletion has succeeded
reddycharan opened a new pull request #2206: Remove lock from URManager’s state only if lock znode deletion has succeeded
URL: https://github.com/apache/bookkeeper/pull/2206
Descriptions of the changes in this PR:
- in ZkLedgerUnderreplicationManager.releaseUnderreplicatedLedger remove ‘lock’
from ‘heldLocks’ only if lock znode deletion has succeeded.
- This is needed because, if RW.logBKExceptionAndReleaseLedger fails to delete
the lock znode, then it needs to be tried once more in the finally block of
'rereplicate(long ledgerIdToReplicate)’ before giving up and shutting down RW.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services