[GitHub] [spark] Yikun edited a comment on pull request #32122: [SPARK-35019][PYTHON][SQL]Fix type hints mismatches in pyspark.sql.*

[GitBox <gi...@apache.org>]

Yikun edited a comment on pull request #32122:
URL: https://github.com/apache/spark/pull/32122#issuecomment-817750241


   Thanks for your detail and patient explanation for the background of type hints, learned a lot : ) and really much thanks for your previous effort on python stub works.
   
   And I started to the annotions fix work because I saw [SPARK-34629](https://issues.apache.org/jira/browse/SPARK-34629) is `OPEN` and have a short discussion with @HyukjinKwon, and found there's some mismatches on type hints, so I thought maybe can help some on it. I believe maybe there are many other people also have will to help it.
   
   > We should probably avoid fixing individual, low priority (not bug, not reported as an issue) annotations in separate PRs, to keep review work managable, but I don't think its a problem here.
   
   Definately yes, I was going to fix these type annotations by module ranther than by file or smaller granularity (such as this patch, I looked in deep in every files under the pyspark.sql.*), I also considered the huge patch will hard to review, so I just submit it in the score of module. And also, I paste the origin py lines for every pyi.
   
   > I am bit preoccupied lately, but if you plan to work more on this part and have any questions, please let me know.
   
   I really know about the difficult of fix these (due to large amount of py files and needs to be very careful), but I'm still not sure it's (I mean fix and submit it by module) the good way  to improve pyspark hints or not. If yes, I will continue this work when I have time; if not, maybe we also need to find a better way to let more people join.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org