You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by wu...@apache.org on 2020/08/24 07:02:15 UTC
[skywalking] branch master updated: change alarm module
silence-period default value as same as period. (#5372)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 450a7ec change alarm module silence-period default value as same as period. (#5372)
450a7ec is described below
commit 450a7ec4e02f7e5a6b2e8f474dbf71c589effc6a
Author: zifeihan <de...@gmail.com>
AuthorDate: Mon Aug 24 15:01:59 2020 +0800
change alarm module silence-period default value as same as period. (#5372)
Co-authored-by: echo <zi...@foxmail.com>
---
.../apache/skywalking/oap/server/core/alarm/provider/RulesReader.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RulesReader.java b/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RulesReader.java
index 9f5f947..e0909de 100644
--- a/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RulesReader.java
+++ b/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RulesReader.java
@@ -76,7 +76,8 @@ public class RulesReader {
alarmRule.setOp((String) settings.get("op"));
alarmRule.setPeriod((Integer) settings.getOrDefault("period", 1));
alarmRule.setCount((Integer) settings.getOrDefault("count", 1));
- alarmRule.setSilencePeriod((Integer) settings.getOrDefault("silence-period", -1));
+ // How many times of checks, the alarm keeps silence after alarm triggered, default as same as period.
+ alarmRule.setSilencePeriod((Integer) settings.getOrDefault("silence-period", alarmRule.getPeriod()));
alarmRule.setMessage(
(String) settings.getOrDefault("message", "Alarm caused by Rule " + alarmRule
.getAlarmRuleName()));