You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/09/01 09:23:33 UTC
[GitHub] [cordova-plugin-camera] silvanadrian opened a new pull request #760: fix(ios): video quality
silvanadrian opened a new pull request #760:
URL: https://github.com/apache/cordova-plugin-camera/pull/760
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
ios
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
I use the `cordova-camera-plugin` to upload videos to youtube at which time I realized that literally every upload ends up on being `sd` only even though most smartphones these days are able to record much higher resolution videos.
**Before the change:**
<img width="372" alt="Screenshot 2021-08-31 at 22 32 02" src="https://user-images.githubusercontent.com/1950155/131572141-6220ab1a-52d6-42fa-b1d5-146b9eb872c6.png">
**After the change:**
<img width="379" alt="Screenshot 2021-08-31 at 22 21 53" src="https://user-images.githubusercontent.com/1950155/131572224-1832e8cc-6171-4f27-b392-7c11cf548673.png">
(compression gets skipped, just shows up very shortly)
Closes https://github.com/apache/cordova-plugin-camera/issues/732
### Description
<!-- Describe your changes in detail -->
At the moment it's more of a quickfix than a proper solution, I guess I can even improve it further by adding a video quality option to the `CameraOptions` then everyone can choose themselfs if they would want to be able to get higher resolution videos.
Does anyone have an opinion on that?
For reference: https://stackoverflow.com/questions/20190485/how-to-avoid-compression-after-selecting-video-from-uiimagepickercontroller-in-i
### Testing
<!-- Please describe in detail how you tested your changes. -->
As described tested it by uploading the same video 2 times to youtube from a iPhone to make sure that a higher resolution video got uploaded which was the case.
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] davidcopano edited a comment on pull request #760: fix(ios): video quality
Posted by GitBox <gi...@apache.org>.
davidcopano edited a comment on pull request #760:
URL: https://github.com/apache/cordova-plugin-camera/pull/760#issuecomment-950677648
Thanks to this fork, I was able to choose videos from iOS devices correctly, with the original plugin the app would close almost immediately. This pull request should be merged as soon as possible.
To future readers, you can install this useful fork executing this command:
`cordova plugin rm cordova-plugin-camera; cordova plugin add https://github.com/silvanadrian/cordova-plugin-camera.git#fix/video-quality-ios`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] davidcopano commented on pull request #760: fix(ios): video quality
Posted by GitBox <gi...@apache.org>.
davidcopano commented on pull request #760:
URL: https://github.com/apache/cordova-plugin-camera/pull/760#issuecomment-950677648
Thanks to this fork, I was able to choose videos from iOS devices correctly, with the original plugin the app would close almost immediately. This pull request should be merged as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] Siedlerchr commented on pull request #760: fix(ios): video quality
Posted by GitBox <gi...@apache.org>.
Siedlerchr commented on pull request #760:
URL: https://github.com/apache/cordova-plugin-camera/pull/760#issuecomment-1013127739
This fix works only for selecting existing videos from the photo library, not for taking new videos.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org