You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Narayan Periwal <na...@inmobi.com> on 2015/11/19 10:40:04 UTC

Review Request 40474: FALCON-1557: Supporting some Entity Management Api's and admin api in Falcon Unit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40474/
-----------------------------------------------------------

Review request for Falcon.


Bugs: FALCON-1557
    https://issues.apache.org/jira/browse/FALCON-1557


Repository: falcon-git


Description
-------

Entity Management Api's such as summary, list, submitAndSchedule, touch, etc. and admin api should be supported by Falcon Unit


Diffs
-----

  client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 27b93c0 
  client/src/main/java/org/apache/falcon/client/FalconClient.java c49dd08 
  oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7262964 
  oozie/src/main/java/org/apache/oozie/client/LocalOozieClientCoordProxy.java 093d6ff 
  oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java 6ae92de 
  prism/src/main/java/org/apache/falcon/resource/admin/AdminResource.java ace21cb 
  unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 9f2b714 
  unit/src/main/java/org/apache/falcon/unit/LocalSchedulableEntityManager.java 42adc9a 
  unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 42cb779 
  unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 2c8642d 
  webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 8dbbd7d 
  webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java 37442c3 

Diff: https://reviews.apache.org/r/40474/diff/


Testing
-------

Done.


Thanks,

Narayan Periwal


Re: Review Request 40474: FALCON-1557: Supporting some Entity Management Api's and admin api in Falcon Unit

Posted by Narayan Periwal <na...@inmobi.com>.

> On Nov. 19, 2015, 10:53 a.m., pavan kumar kolamuri wrote:
> > unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java, line 358
> > <https://reviews.apache.org/r/40474/diff/1/?file=1131864#file1131864line358>
> >
> >     Please add touch in update method, update and touch can be grouped but not here

OK. Makes sense.


> On Nov. 19, 2015, 10:53 a.m., pavan kumar kolamuri wrote:
> > webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java, line 256
> > <https://reviews.apache.org/r/40474/diff/1/?file=1131865#file1131865line256>
> >
> >     did assertInstance method still required as you removed everywhere ?

There are some places in ProcessInstanceManagerIT that still uses this method. So, its still required.


> On Nov. 19, 2015, 10:53 a.m., pavan kumar kolamuri wrote:
> > unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java, line 196
> > <https://reviews.apache.org/r/40474/diff/1/?file=1131864#file1131864line196>
> >
> >     Please change other places also

Ok. Makes sense.


> On Nov. 19, 2015, 10:53 a.m., pavan kumar kolamuri wrote:
> > unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java, line 352
> > <https://reviews.apache.org/r/40474/diff/1/?file=1131864#file1131864line352>
> >
> >     Please add different test for summary, as it has lot of functionalities we can add later

Yes I will add this.


- Narayan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40474/#review107156
-----------------------------------------------------------


On Nov. 19, 2015, 9:40 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40474/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 9:40 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1557
>     https://issues.apache.org/jira/browse/FALCON-1557
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Entity Management Api's such as summary, list, submitAndSchedule, touch, etc. and admin api should be supported by Falcon Unit
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 27b93c0 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java c49dd08 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7262964 
>   oozie/src/main/java/org/apache/oozie/client/LocalOozieClientCoordProxy.java 093d6ff 
>   oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java 6ae92de 
>   prism/src/main/java/org/apache/falcon/resource/admin/AdminResource.java ace21cb 
>   unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 9f2b714 
>   unit/src/main/java/org/apache/falcon/unit/LocalSchedulableEntityManager.java 42adc9a 
>   unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 42cb779 
>   unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 2c8642d 
>   webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 8dbbd7d 
>   webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java 37442c3 
> 
> Diff: https://reviews.apache.org/r/40474/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Re: Review Request 40474: FALCON-1557: Supporting some Entity Management Api's and admin api in Falcon Unit

Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40474/#review107156
-----------------------------------------------------------



unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 73)
<https://reviews.apache.org/r/40474/#comment166116>

    Pls don't change this as it unnecessarily launch lot of instances though might be waiting.



unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 116)
<https://reviews.apache.org/r/40474/#comment166117>

    change here



unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 141)
<https://reviews.apache.org/r/40474/#comment166118>

    here also



unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 190)
<https://reviews.apache.org/r/40474/#comment166119>

    Please change other places also



unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 343)
<https://reviews.apache.org/r/40474/#comment166127>

    Is it possible to check entityName also ?



unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 344)
<https://reviews.apache.org/r/40474/#comment166126>

    Please add different test for summary, as it has lot of functionalities we can add later



unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 350)
<https://reviews.apache.org/r/40474/#comment166125>

    Please add touch in update method, update and touch can be grouped but not here



webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java (line 256)
<https://reviews.apache.org/r/40474/#comment166128>

    did assertInstance method still required as you removed everywhere ?


- pavan kumar kolamuri


On Nov. 19, 2015, 9:40 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40474/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 9:40 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1557
>     https://issues.apache.org/jira/browse/FALCON-1557
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Entity Management Api's such as summary, list, submitAndSchedule, touch, etc. and admin api should be supported by Falcon Unit
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 27b93c0 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java c49dd08 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7262964 
>   oozie/src/main/java/org/apache/oozie/client/LocalOozieClientCoordProxy.java 093d6ff 
>   oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java 6ae92de 
>   prism/src/main/java/org/apache/falcon/resource/admin/AdminResource.java ace21cb 
>   unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 9f2b714 
>   unit/src/main/java/org/apache/falcon/unit/LocalSchedulableEntityManager.java 42adc9a 
>   unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 42cb779 
>   unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 2c8642d 
>   webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 8dbbd7d 
>   webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java 37442c3 
> 
> Diff: https://reviews.apache.org/r/40474/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Re: Review Request 40474: FALCON-1557: Supporting some Entity Management Api's and admin api in Falcon Unit

Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40474/#review107723
-----------------------------------------------------------

Ship it!


Ship It!

- Pallavi Rao


On Nov. 24, 2015, 6:10 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40474/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2015, 6:10 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1557
>     https://issues.apache.org/jira/browse/FALCON-1557
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Entity Management Api's such as summary, list, submitAndSchedule, touch, etc. and admin api should be supported by Falcon Unit
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 27b93c0 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java c49dd08 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java b1cec41 
>   oozie/src/main/java/org/apache/oozie/client/LocalOozieClientCoordProxy.java 093d6ff 
>   oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java 6ae92de 
>   prism/src/main/java/org/apache/falcon/resource/admin/AdminResource.java ace21cb 
>   unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 9f2b714 
>   unit/src/main/java/org/apache/falcon/unit/LocalSchedulableEntityManager.java 42adc9a 
>   unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 42cb779 
>   unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 2c8642d 
>   webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 8dbbd7d 
>   webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java 37442c3 
> 
> Diff: https://reviews.apache.org/r/40474/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Re: Review Request 40474: FALCON-1557: Supporting some Entity Management Api's and admin api in Falcon Unit

Posted by Narayan Periwal <na...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40474/
-----------------------------------------------------------

(Updated Nov. 24, 2015, 6:10 a.m.)


Review request for Falcon.


Bugs: FALCON-1557
    https://issues.apache.org/jira/browse/FALCON-1557


Repository: falcon-git


Description
-------

Entity Management Api's such as summary, list, submitAndSchedule, touch, etc. and admin api should be supported by Falcon Unit


Diffs (updated)
-----

  client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 27b93c0 
  client/src/main/java/org/apache/falcon/client/FalconClient.java c49dd08 
  oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java b1cec41 
  oozie/src/main/java/org/apache/oozie/client/LocalOozieClientCoordProxy.java 093d6ff 
  oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java 6ae92de 
  prism/src/main/java/org/apache/falcon/resource/admin/AdminResource.java ace21cb 
  unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 9f2b714 
  unit/src/main/java/org/apache/falcon/unit/LocalSchedulableEntityManager.java 42adc9a 
  unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 42cb779 
  unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 2c8642d 
  webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 8dbbd7d 
  webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java 37442c3 

Diff: https://reviews.apache.org/r/40474/diff/


Testing
-------

Done.


Thanks,

Narayan Periwal


Re: Review Request 40474: FALCON-1557: Supporting some Entity Management Api's and admin api in Falcon Unit

Posted by Narayan Periwal <na...@inmobi.com>.

> On Nov. 24, 2015, 4:18 a.m., Pallavi Rao wrote:
> > unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java, line 359
> > <https://reviews.apache.org/r/40474/diff/2/?file=1134010#file1134010line359>
> >
> >     This will make the string start with a comma, doesn't it? The if condition should be after the property is appended (In which case you will have to handle the extra comma at the end.)

Its properties.length, not propertytList.length. Initially the length of properties is zero, so comma will not be appended.


- Narayan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40474/#review107708
-----------------------------------------------------------


On Nov. 20, 2015, 8:20 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40474/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2015, 8:20 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1557
>     https://issues.apache.org/jira/browse/FALCON-1557
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Entity Management Api's such as summary, list, submitAndSchedule, touch, etc. and admin api should be supported by Falcon Unit
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 27b93c0 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java c49dd08 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7262964 
>   oozie/src/main/java/org/apache/oozie/client/LocalOozieClientCoordProxy.java 093d6ff 
>   oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java 6ae92de 
>   prism/src/main/java/org/apache/falcon/resource/admin/AdminResource.java ace21cb 
>   unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 9f2b714 
>   unit/src/main/java/org/apache/falcon/unit/LocalSchedulableEntityManager.java 42adc9a 
>   unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 42cb779 
>   unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 2c8642d 
>   webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 8dbbd7d 
>   webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java 37442c3 
> 
> Diff: https://reviews.apache.org/r/40474/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Re: Review Request 40474: FALCON-1557: Supporting some Entity Management Api's and admin api in Falcon Unit

Posted by Pallavi Rao <pa...@inmobi.com>.

> On Nov. 24, 2015, 4:18 a.m., Pallavi Rao wrote:
> > unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java, line 359
> > <https://reviews.apache.org/r/40474/diff/2/?file=1134010#file1134010line359>
> >
> >     This will make the string start with a comma, doesn't it? The if condition should be after the property is appended (In which case you will have to handle the extra comma at the end.)
> 
> Narayan Periwal wrote:
>     Its properties.length, not propertytList.length. Initially the length of properties is zero, so comma will not be appended.

My bad. I misread. Sounds good.


- Pallavi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40474/#review107708
-----------------------------------------------------------


On Nov. 20, 2015, 8:20 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40474/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2015, 8:20 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1557
>     https://issues.apache.org/jira/browse/FALCON-1557
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Entity Management Api's such as summary, list, submitAndSchedule, touch, etc. and admin api should be supported by Falcon Unit
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 27b93c0 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java c49dd08 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7262964 
>   oozie/src/main/java/org/apache/oozie/client/LocalOozieClientCoordProxy.java 093d6ff 
>   oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java 6ae92de 
>   prism/src/main/java/org/apache/falcon/resource/admin/AdminResource.java ace21cb 
>   unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 9f2b714 
>   unit/src/main/java/org/apache/falcon/unit/LocalSchedulableEntityManager.java 42adc9a 
>   unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 42cb779 
>   unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 2c8642d 
>   webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 8dbbd7d 
>   webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java 37442c3 
> 
> Diff: https://reviews.apache.org/r/40474/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Re: Review Request 40474: FALCON-1557: Supporting some Entity Management Api's and admin api in Falcon Unit

Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40474/#review107708
-----------------------------------------------------------



unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java (line 359)
<https://reviews.apache.org/r/40474/#comment166986>

    This will make the string start with a comma, doesn't it? The if condition should be after the property is appended (In which case you will have to handle the extra comma at the end.)



unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 208)
<https://reviews.apache.org/r/40474/#comment166987>

    Use assertStatus method.



unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 331)
<https://reviews.apache.org/r/40474/#comment166988>

    Call it testEntityList, instead?


- Pallavi Rao


On Nov. 20, 2015, 8:20 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40474/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2015, 8:20 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1557
>     https://issues.apache.org/jira/browse/FALCON-1557
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Entity Management Api's such as summary, list, submitAndSchedule, touch, etc. and admin api should be supported by Falcon Unit
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 27b93c0 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java c49dd08 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7262964 
>   oozie/src/main/java/org/apache/oozie/client/LocalOozieClientCoordProxy.java 093d6ff 
>   oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java 6ae92de 
>   prism/src/main/java/org/apache/falcon/resource/admin/AdminResource.java ace21cb 
>   unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 9f2b714 
>   unit/src/main/java/org/apache/falcon/unit/LocalSchedulableEntityManager.java 42adc9a 
>   unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 42cb779 
>   unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 2c8642d 
>   webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 8dbbd7d 
>   webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java 37442c3 
> 
> Diff: https://reviews.apache.org/r/40474/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Re: Review Request 40474: FALCON-1557: Supporting some Entity Management Api's and admin api in Falcon Unit

Posted by Narayan Periwal <na...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40474/
-----------------------------------------------------------

(Updated Nov. 20, 2015, 8:20 a.m.)


Review request for Falcon.


Bugs: FALCON-1557
    https://issues.apache.org/jira/browse/FALCON-1557


Repository: falcon-git


Description
-------

Entity Management Api's such as summary, list, submitAndSchedule, touch, etc. and admin api should be supported by Falcon Unit


Diffs (updated)
-----

  client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 27b93c0 
  client/src/main/java/org/apache/falcon/client/FalconClient.java c49dd08 
  oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7262964 
  oozie/src/main/java/org/apache/oozie/client/LocalOozieClientCoordProxy.java 093d6ff 
  oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java 6ae92de 
  prism/src/main/java/org/apache/falcon/resource/admin/AdminResource.java ace21cb 
  unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 9f2b714 
  unit/src/main/java/org/apache/falcon/unit/LocalSchedulableEntityManager.java 42adc9a 
  unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 42cb779 
  unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 2c8642d 
  webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 8dbbd7d 
  webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java 37442c3 

Diff: https://reviews.apache.org/r/40474/diff/


Testing
-------

Done.


Thanks,

Narayan Periwal