You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by "Jukka Zitting (JIRA)" <ji...@apache.org> on 2011/08/26 12:22:29 UTC
[jira] [Created] (TIKA-699) Automatic checks against
backwards-incompatible API changes
Automatic checks against backwards-incompatible API changes
-----------------------------------------------------------
Key: TIKA-699
URL: https://issues.apache.org/jira/browse/TIKA-699
Project: Tika
Issue Type: Improvement
Reporter: Jukka Zitting
As we get closer to 1.x we should add tooling like the Maven Clirr plugin [1] to guard against accidental backwards-incompatible API changes.
[1] http://mojo.codehaus.org/clirr-maven-plugin/
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Created] (TIKA-699) Automatic checks against
backwards-incompatible API changes
Posted by Oleg Tikhonov <ol...@apache.org>.
I'm in favor, +1.
On Fri, Aug 26, 2011 at 1:22 PM, Jukka Zitting (JIRA) <ji...@apache.org>wrote:
> Automatic checks against backwards-incompatible API changes
> -----------------------------------------------------------
>
> Key: TIKA-699
> URL: https://issues.apache.org/jira/browse/TIKA-699
> Project: Tika
> Issue Type: Improvement
> Reporter: Jukka Zitting
>
>
> As we get closer to 1.x we should add tooling like the Maven Clirr plugin
> [1] to guard against accidental backwards-incompatible API changes.
>
> [1] http://mojo.codehaus.org/clirr-maven-plugin/
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
[jira] [Resolved] (TIKA-699) Automatic checks against
backwards-incompatible API changes
Posted by "Jukka Zitting (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TIKA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting resolved TIKA-699.
--------------------------------
Resolution: Fixed
Fix Version/s: 1.0
Assignee: Jukka Zitting
Added checks for tika-core in revision 1179318.
> Automatic checks against backwards-incompatible API changes
> -----------------------------------------------------------
>
> Key: TIKA-699
> URL: https://issues.apache.org/jira/browse/TIKA-699
> Project: Tika
> Issue Type: Improvement
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Fix For: 1.0
>
> Attachments: 0001-TIKA-699-Automatic-checks-against-backwards-incompat.patch
>
>
> As we get closer to 1.x we should add tooling like the Maven Clirr plugin [1] to guard against accidental backwards-incompatible API changes.
> [1] http://mojo.codehaus.org/clirr-maven-plugin/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TIKA-699) Automatic checks against
backwards-incompatible API changes
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TIKA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated TIKA-699:
-------------------------------
Attachment: 0001-TIKA-699-Automatic-checks-against-backwards-incompat.patch
The attached patch adds the required clirr-maven-plugin configuration.
It currently reports the following problems:
{quote}
[ERROR] org.apache.tika.io.ByteArrayOutputStream: Class org.apache.tika.io.ByteArrayOutputStream removed
[ERROR] org.apache.tika.io.IOUtils: Method 'public java.io.InputStream toBufferedInputStream(java.io.InputStream)' has been removed
[ERROR] org.apache.tika.metadata.MSOffice: Changed type of field LAST_PRINTED from java.lang.String to org.apache.tika.metadata.Property
[ERROR] org.apache.tika.metadata.MSOffice: Changed type of field LAST_SAVED from java.lang.String to org.apache.tika.metadata.Property
[ERROR] org.apache.tika.sax.SecureContentHandler: Parameter 2 of 'public SecureContentHandler(org.xml.sax.ContentHandler, org.apache.tika.io.CountingInputStream)' has changed its type to org.apache.tika.io.TikaInputStream
{quote}
The first two are from revision 1125422 for TIKA-375 to get rid of unused code.
The second two are from revision 1100053 for TIKA-656 to get properly typed metadata keys.
The last one is from revision 1124385 for TIKA-645 to avoid extra layers of stream wrapping.
All of these could we worked around fairly easily to restore full backwards compatibility to Tika 0.9. The question is whether we want to do so, especially since the jump from 0.x to 1.x offers a clean point for getting rid of old baggage in the API.
If we don't want to fix these issues, then we should commit this change only after 1.0 is released, and use the 1.0 release as the reference point for future compatibility checks.
> Automatic checks against backwards-incompatible API changes
> -----------------------------------------------------------
>
> Key: TIKA-699
> URL: https://issues.apache.org/jira/browse/TIKA-699
> Project: Tika
> Issue Type: Improvement
> Reporter: Jukka Zitting
> Attachments: 0001-TIKA-699-Automatic-checks-against-backwards-incompat.patch
>
>
> As we get closer to 1.x we should add tooling like the Maven Clirr plugin [1] to guard against accidental backwards-incompatible API changes.
> [1] http://mojo.codehaus.org/clirr-maven-plugin/
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TIKA-699) Automatic checks against
backwards-incompatible API changes
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TIKA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13091736#comment-13091736 ]
Michael McCandless commented on TIKA-699:
-----------------------------------------
+1, this sounds awesome.
We could really use this in Lucene too!
> Automatic checks against backwards-incompatible API changes
> -----------------------------------------------------------
>
> Key: TIKA-699
> URL: https://issues.apache.org/jira/browse/TIKA-699
> Project: Tika
> Issue Type: Improvement
> Reporter: Jukka Zitting
>
> As we get closer to 1.x we should add tooling like the Maven Clirr plugin [1] to guard against accidental backwards-incompatible API changes.
> [1] http://mojo.codehaus.org/clirr-maven-plugin/
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira