You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/01/12 13:29:37 UTC

Review Request 55458: Added validation for a general check.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55458/
-----------------------------------------------------------

Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.


Bugs: MESOS-6906
    https://issues.apache.org/jira/browse/MESOS-6906


Repository: mesos


Description
-------

See summary.


Diffs
-----

  src/CMakeLists.txt ce71afc73f85a70cd8f97a6e913662ff7ef0d94c 
  src/Makefile.am 333b45683a10eaac3b653e006511306d8054922c 
  src/checks/checker.hpp PRE-CREATION 
  src/checks/checker.cpp PRE-CREATION 
  src/master/validation.hpp 57e81779ff7444904c2ad7bad33aaf9167b98d05 
  src/master/validation.cpp 96aa36585ded4bd7cf98526f710ccbc4f23b1f0f 

Diff: https://reviews.apache.org/r/55458/diff/


Testing
-------

See https://reviews.apache.org/r/55459/


Thanks,

Alexander Rukletsov

Re: Review Request 55458: Added validation for a general check.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55458/#review162560
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Jan. 20, 2017, 2:49 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55458/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2017, 2:49 p.m.)
> 
> 
> Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6906
>     https://issues.apache.org/jira/browse/MESOS-6906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt f242d47cb03eb67f299c84643edf23f3f6f313bb 
>   src/Makefile.am 3d0e82cb522d379923e00e5e98e9c9f646fdd3db 
>   src/checks/checker.hpp PRE-CREATION 
>   src/checks/checker.cpp PRE-CREATION 
>   src/checks/health_checker.hpp 59831b12b99b87c15a51a7aa6c43b23be2c42a26 
>   src/master/validation.hpp 78b70a78536cd850cf56b832b575091b2e115284 
>   src/master/validation.cpp 5f134b781901f2de6a90fa6a10d42cc7629c27a0 
>   src/slave/validation.cpp 7f1ba93b03da9f915c89a632effa8309ed6a7545 
> 
> Diff: https://reviews.apache.org/r/55458/diff/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/55459/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 55458: Added validation for a general check.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55458/
-----------------------------------------------------------

(Updated Jan. 20, 2017, 2:49 p.m.)


Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.


Changes
-------

Vinod's comments + extra validation.


Bugs: MESOS-6906
    https://issues.apache.org/jira/browse/MESOS-6906


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  src/CMakeLists.txt f242d47cb03eb67f299c84643edf23f3f6f313bb 
  src/Makefile.am 3d0e82cb522d379923e00e5e98e9c9f646fdd3db 
  src/checks/checker.hpp PRE-CREATION 
  src/checks/checker.cpp PRE-CREATION 
  src/checks/health_checker.hpp 59831b12b99b87c15a51a7aa6c43b23be2c42a26 
  src/master/validation.hpp 78b70a78536cd850cf56b832b575091b2e115284 
  src/master/validation.cpp 5f134b781901f2de6a90fa6a10d42cc7629c27a0 
  src/slave/validation.cpp 7f1ba93b03da9f915c89a632effa8309ed6a7545 

Diff: https://reviews.apache.org/r/55458/diff/


Testing
-------

See https://reviews.apache.org/r/55459/


Thanks,

Alexander Rukletsov

Re: Review Request 55458: Added validation for a general check.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55458/
-----------------------------------------------------------

(Updated Jan. 19, 2017, 5:46 p.m.)


Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.


Changes
-------

Rebased.


Bugs: MESOS-6906
    https://issues.apache.org/jira/browse/MESOS-6906


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  src/CMakeLists.txt c06baf3a926687c7c6161025ae4a534dbae637e4 
  src/Makefile.am 3d0e82cb522d379923e00e5e98e9c9f646fdd3db 
  src/checks/checker.hpp PRE-CREATION 
  src/checks/checker.cpp PRE-CREATION 
  src/master/validation.hpp 78b70a78536cd850cf56b832b575091b2e115284 
  src/master/validation.cpp 5f134b781901f2de6a90fa6a10d42cc7629c27a0 

Diff: https://reviews.apache.org/r/55458/diff/


Testing
-------

See https://reviews.apache.org/r/55459/


Thanks,

Alexander Rukletsov

Re: Review Request 55458: Added validation for a general check.

Posted by Alexander Rukletsov <ru...@gmail.com>.

> On Jan. 18, 2017, 11:33 a.m., Vinod Kone wrote:
> > src/checks/checker.hpp, line 31
> > <https://reviews.apache.org/r/55458/diff/2/?file=1607434#file1607434line31>
> >
> >     This should be
> >     
> >     ```
> >     Option<Error> validate(const CheckInfo& check);
> >     ```

I don't think so, since it lives in `validation` namespace. This is also what we do for health checks.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55458/#review162067
-----------------------------------------------------------


On Jan. 18, 2017, 9:31 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55458/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2017, 9:31 a.m.)
> 
> 
> Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6906
>     https://issues.apache.org/jira/browse/MESOS-6906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt c06baf3a926687c7c6161025ae4a534dbae637e4 
>   src/Makefile.am 3d0e82cb522d379923e00e5e98e9c9f646fdd3db 
>   src/checks/checker.hpp PRE-CREATION 
>   src/checks/checker.cpp PRE-CREATION 
>   src/master/validation.hpp 78b70a78536cd850cf56b832b575091b2e115284 
>   src/master/validation.cpp 5f134b781901f2de6a90fa6a10d42cc7629c27a0 
> 
> Diff: https://reviews.apache.org/r/55458/diff/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/55459/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 55458: Added validation for a general check.

Posted by Alexander Rukletsov <ru...@gmail.com>.

> On Jan. 18, 2017, 11:33 a.m., Vinod Kone wrote:
> > src/checks/checker.cpp, line 45
> > <https://reviews.apache.org/r/55458/diff/2/?file=1607435#file1607435line45>
> >
> >     don't you want to validate that `check.command().has_command()` ?

Probably not, this is a required field.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55458/#review162067
-----------------------------------------------------------


On Jan. 18, 2017, 9:31 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55458/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2017, 9:31 a.m.)
> 
> 
> Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6906
>     https://issues.apache.org/jira/browse/MESOS-6906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt c06baf3a926687c7c6161025ae4a534dbae637e4 
>   src/Makefile.am 3d0e82cb522d379923e00e5e98e9c9f646fdd3db 
>   src/checks/checker.hpp PRE-CREATION 
>   src/checks/checker.cpp PRE-CREATION 
>   src/master/validation.hpp 78b70a78536cd850cf56b832b575091b2e115284 
>   src/master/validation.cpp 5f134b781901f2de6a90fa6a10d42cc7629c27a0 
> 
> Diff: https://reviews.apache.org/r/55458/diff/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/55459/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 55458: Added validation for a general check.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55458/#review162067
-----------------------------------------------------------




src/checks/checker.hpp (line 31)
<https://reviews.apache.org/r/55458/#comment233316>

    This should be
    
    ```
    Option<Error> validate(const CheckInfo& check);
    ```



src/checks/checker.cpp (line 45)
<https://reviews.apache.org/r/55458/#comment233319>

    don't you want to validate that `check.command().has_command()` ?


- Vinod Kone


On Jan. 18, 2017, 9:31 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55458/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2017, 9:31 a.m.)
> 
> 
> Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6906
>     https://issues.apache.org/jira/browse/MESOS-6906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt c06baf3a926687c7c6161025ae4a534dbae637e4 
>   src/Makefile.am 3d0e82cb522d379923e00e5e98e9c9f646fdd3db 
>   src/checks/checker.hpp PRE-CREATION 
>   src/checks/checker.cpp PRE-CREATION 
>   src/master/validation.hpp 78b70a78536cd850cf56b832b575091b2e115284 
>   src/master/validation.cpp 5f134b781901f2de6a90fa6a10d42cc7629c27a0 
> 
> Diff: https://reviews.apache.org/r/55458/diff/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/55459/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 55458: Added validation for a general check.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55458/
-----------------------------------------------------------

(Updated Jan. 18, 2017, 9:31 a.m.)


Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.


Changes
-------

Rebased.


Bugs: MESOS-6906
    https://issues.apache.org/jira/browse/MESOS-6906


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  src/CMakeLists.txt c06baf3a926687c7c6161025ae4a534dbae637e4 
  src/Makefile.am 3d0e82cb522d379923e00e5e98e9c9f646fdd3db 
  src/checks/checker.hpp PRE-CREATION 
  src/checks/checker.cpp PRE-CREATION 
  src/master/validation.hpp 78b70a78536cd850cf56b832b575091b2e115284 
  src/master/validation.cpp 5f134b781901f2de6a90fa6a10d42cc7629c27a0 

Diff: https://reviews.apache.org/r/55458/diff/


Testing
-------

See https://reviews.apache.org/r/55459/


Thanks,

Alexander Rukletsov