You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@nemo.apache.org by GitBox <gi...@apache.org> on 2019/12/06 05:38:33 UTC

[GitHub] [incubator-nemo] hy00nc commented on issue #273: [Nemo-429] SWPP TEAM15 Code Smell Fix

hy00nc commented on issue #273: [Nemo-429] SWPP TEAM15 Code Smell Fix
URL: https://github.com/apache/incubator-nemo/pull/273#issuecomment-562440025
 
 
   > Just one question,
   > 
   > https://github.com/apache/incubator-nemo/blob/128dc3d399694460eac2c5ac6a698952f3790449/runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/stores/GlusterFileStore.java#L125
   > 
   > this method does not have `@throws` annotation, was it intentional?
   
   Nice catch! I think it is not intentional, but since other classes like LocalFileStore also does not have the @throws, let’s leave it as it is. Thanks😄

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services