You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2019/07/18 17:51:00 UTC
[jira] [Commented] (RATIS-625) LogSegment#append leaks entryCache
when the entries are loaded on a restart.
[ https://issues.apache.org/jira/browse/RATIS-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888199#comment-16888199 ]
Hadoop QA commented on RATIS-625:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m 1s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 26s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m 7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 5s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 37m 16s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 17s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 60m 2s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.examples.filestore.TestFileStoreWithNetty |
| | ratis.logservice.server.TestMetaServer |
| | ratis.logservice.TestLogServiceWithNetty |
| | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc |
| | ratis.grpc.TestRaftServerWithGrpc |
| | ratis.grpc.TestGroupInfoWithGrpc |
| | ratis.grpc.TestRaftSnapshotWithGrpc |
| | ratis.grpc.TestRaftOutputStreamWithGrpc |
| | ratis.grpc.TestWatchRequestWithGrpc |
| | ratis.grpc.TestRaftWithGrpc |
| | ratis.grpc.TestInstallSnapshotWithGrpc |
| | ratis.grpc.TestGroupManagementWithGrpc |
| | ratis.server.simulation.TestGroupInfoWithSimulatedRpc |
| | ratis.grpc.TestRaftAsyncWithGrpc |
| | ratis.server.simulation.TestRaftWithSimulatedRpc |
| | ratis.grpc.TestRaftStateMachineExceptionWithGrpc |
| | ratis.grpc.TestStateMachineShutdownWithGrpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=18.09.7 Server=18.09.7 Image:yetus/ratis:date2019-07-18 |
| JIRA Issue | RATIS-625 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12975178/RATIS-625.001.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs checkstyle compile |
| uname | Linux 35aa9f16ea35 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh |
| git revision | master / c2a6a24 |
| maven | version: Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T18:41:47Z) |
| Default Java | 1.8.0_212 |
| unit | https://builds.apache.org/job/PreCommit-RATIS-Build/904/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/PreCommit-RATIS-Build/904/testReport/ |
| asflicense | https://builds.apache.org/job/PreCommit-RATIS-Build/904/artifact/out/patch-asflicense-problems.txt |
| Max. process+thread count | 2734 (vs. ulimit of 5000) |
| modules | C: ratis-server U: ratis-server |
| Console output | https://builds.apache.org/job/PreCommit-RATIS-Build/904/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> LogSegment#append leaks entryCache when the entries are loaded on a restart.
> ----------------------------------------------------------------------------
>
> Key: RATIS-625
> URL: https://issues.apache.org/jira/browse/RATIS-625
> Project: Ratis
> Issue Type: Bug
> Components: server
> Affects Versions: 0.3.0
> Reporter: Mukul Kumar Singh
> Assignee: Mukul Kumar Singh
> Priority: Major
> Attachments: RATIS-625.001.patch
>
>
> LogSegment#append leaks the entryCache when a RaftServerImpl is restarted.
> On restart, the entries are loaded from the raft Logs and then added in the entryCache, however after adding the entry in the cache, hasEntryCache is not set to true.
> cc: [~ljain] [~szetszwo]
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)