You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2026/03/23 10:32:43 UTC

[PR] CAMEL-23225: Propagate OpenTelemetry context across thread boundaries in camel-opentelemetry2 [camel]

gnodet opened a new pull request, #22190:
URL: https://github.com/apache/camel/pull/22190

   ## Summary
   
   - Port thread pool instrumentation from the deprecated `camel-opentelemetry` module to `camel-opentelemetry2`
   - Add `OpenTelemetryInstrumentedThreadPoolFactory` — wraps Camel-managed `ExecutorService` and `ScheduledExecutorService` with `Context.taskWrapping()` to propagate OTel context
   - Add `OpenTelemetryInstrumentedThreadFactoryListener` — wraps `ThreadFactory` to propagate OTel context via `Context.current().wrap()`
   - Both classes are registered as `@JdkService` so they are automatically discovered by Camel
   
   This prevents OpenTelemetry context leaks when Camel routes use async processing, thread pools, or other multi-threaded patterns. The deprecated `camel-opentelemetry` module had these classes, but they were not carried over when `camel-opentelemetry2` was created.
   
   ## Test plan
   
   - [x] All 12 existing `camel-opentelemetry2` tests pass
   - [x] JDK service files generated correctly for `thread-pool-factory` and `thread-factory-listener`
   - [x] Verified same pattern as deprecated `camel-opentelemetry` module


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23225: Propagate OpenTelemetry context across thread boundaries in camel-opentelemetry2 [camel]

Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #22190:
URL: https://github.com/apache/camel/pull/22190


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23225: Propagate OpenTelemetry context across thread boundaries in camel-opentelemetry2 [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22190:
URL: https://github.com/apache/camel/pull/22190#issuecomment-4109592255

   :star2: Thank you for your contribution to the Apache Camel project! :star2:
     :robot: CI automation will test this PR automatically.
   
     :camel: Apache Camel Committers, please review the following items:
   
     * First-time contributors **require MANUAL approval** for the GitHub Actions to run
     * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
     * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
     * Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
     
     :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23225: Propagate OpenTelemetry context across thread boundaries in camel-opentelemetry2 [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22190:
URL: https://github.com/apache/camel/pull/22190#issuecomment-4109862753

   <!-- ci-tested-modules -->
   :test_tube: **CI tested the following changed modules:**
   
   - `components/camel-opentelemetry2`
   - `dsl/camel-kamelet-main`
   
   <details><summary>All tested modules (74 modules)</summary>
   
   - Camel :: All Components Sync point
   - Camel :: All Components Sync point                                 [pom]
   - Camel :: Assembly
   - Camel :: Assembly                                                  [pom]
   - Camel :: Catalog :: CSimple Maven Plugin (deprecated)     [maven-plugin]
   - Camel :: Catalog :: CSimple Maven Plugin (deprecated) SUCCESS [  1.512 s]
   - Camel :: Catalog :: Camel Catalog
   - Camel :: Catalog :: Camel Catalog                                  [jar]
   - Camel :: Catalog :: Camel Report Maven Plugin
   - Camel :: Catalog :: Camel Report Maven Plugin             [maven-plugin]
   - Camel :: Catalog :: Camel Route Parser
   - Camel :: Catalog :: Camel Route Parser                             [jar]
   - Camel :: Catalog :: Console
   - Camel :: Catalog :: Console                                        [jar]
   - Camel :: Catalog :: Dummy Component
   - Camel :: Catalog :: Dummy Component                                [jar]
   - Camel :: Catalog :: Lucene (deprecated)
   - Camel :: Catalog :: Lucene (deprecated)                            [jar]
   - Camel :: Catalog :: Maven
   - Camel :: Catalog :: Maven                                          [jar]
   - Camel :: Catalog :: Suggest
   - Camel :: Catalog :: Suggest                                        [jar]
   - Camel :: Component DSL
   - Camel :: Component DSL                                             [jar]
   - Camel :: Coverage
   - Camel :: Coverage                                                  [pom]
   - Camel :: Docs
   - Camel :: Docs                                                      [pom]
   - Camel :: Endpoint DSL
   - Camel :: Endpoint DSL                                              [jar]
   - Camel :: Endpoint DSL :: Support
   - Camel :: Endpoint DSL :: Support                                   [jar]
   - Camel :: Integration Tests
   - Camel :: Integration Tests                                         [jar]
   - Camel :: JBang :: Core
   - Camel :: JBang :: Core                                             [jar]
   - Camel :: JBang :: Integration tests
   - Camel :: JBang :: Integration tests                                [jar]
   - Camel :: JBang :: MCP
   - Camel :: JBang :: MCP                                              [jar]
   - Camel :: JBang :: Main
   - Camel :: JBang :: Main                                             [jar]
   - Camel :: JBang :: Plugin :: Edit
   - Camel :: JBang :: Plugin :: Edit                                   [jar]
   - Camel :: JBang :: Plugin :: Generate
   - Camel :: JBang :: Plugin :: Generate                               [jar]
   - Camel :: JBang :: Plugin :: Kubernetes
   - Camel :: JBang :: Plugin :: Kubernetes                             [jar]
   - Camel :: JBang :: Plugin :: Route Parser
   - Camel :: JBang :: Plugin :: Route Parser                           [jar]
   - Camel :: JBang :: Plugin :: Testing
   - Camel :: JBang :: Plugin :: Testing                                [jar]
   - Camel :: JBang :: Plugin :: Validate
   - Camel :: JBang :: Plugin :: Validate                               [jar]
   - Camel :: Kamelet Main
   - Camel :: Kamelet Main                                              [jar]
   - Camel :: Launcher
   - Camel :: Launcher                                                  [jar]
   - Camel :: Launcher :: Container
   - Camel :: Launcher :: Container                                     [pom]
   - Camel :: Observability Services
   - Camel :: Observability Services                                    [jar]
   - Camel :: Opentelemetry 2
   - Camel :: Opentelemetry 2                                           [jar]
   - Camel :: YAML DSL
   - Camel :: YAML DSL                                                  [jar]
   - Camel :: YAML DSL :: Deserializers
   - Camel :: YAML DSL :: Deserializers                                 [jar]
   - Camel :: YAML DSL :: Maven Plugins
   - Camel :: YAML DSL :: Maven Plugins                        [maven-plugin]
   - Camel :: YAML DSL :: Validator
   - Camel :: YAML DSL :: Validator                                     [jar]
   - Camel :: YAML DSL :: Validator Maven Plugin
   - Camel :: YAML DSL :: Validator Maven Plugin               [maven-plugin]
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23225: Propagate OpenTelemetry context across thread boundaries in camel-opentelemetry2 [camel]

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #22190:
URL: https://github.com/apache/camel/pull/22190#issuecomment-4124462992

   Hi folks. I think this one was totally wrong. The propagation mechanism in camel-openetelemetry2 has nothing to do with the ThreadContext propagation, and it was exactly the reason why we had changed that. Please, look at the design constraints defined in https://github.com/apache/camel/blob/main/proposals/tracing.adoc and I strongly advise to revert this completely.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org