You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Klaus Ma <kl...@gmail.com> on 2016/01/23 01:57:39 UTC
Review Request 42678: Avoid `slave.total` do not contain
`slave.allocated` in allocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42678/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-4442
https://issues.apache.org/jira/browse/MESOS-4442
Repository: mesos
Description
-------
Added test case for MESOS-4442.
Diffs
-----
src/tests/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf
Diff: https://reviews.apache.org/r/42678/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 42678: WIP: Avoid `slave.total` do not contain
`slave.allocated` in allocator.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42678/#review115978
-----------------------------------------------------------
Bad review!
Reviews applied: []
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos ReviewBot
On Jan. 23, 2016, 1:16 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42678/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2016, 1:16 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-4442
> https://issues.apache.org/jira/browse/MESOS-4442
>
>
> Repository: mesos
>
>
> Description
> -------
>
> __Phenomenon__:
> In master log, `slave.allocated` may have more resources than `slave.total`.
>
> __Root Cause__:
> Not trace revocable resources in allocator; so the info maybe different between Master/Slave because of race condition.
>
> __Solution/Fix__:
> Trace revocable resources in allocator.
>
>
> Diffs
> -----
>
> src/tests/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf
>
> Diff: https://reviews.apache.org/r/42678/diff/
>
>
> Testing
> -------
>
> make check GTEST_FILTER="OversubscriptionTest.OverOffered"
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 42678: WIP: Avoid `slave.total` do not contain
`slave.allocated` in allocator.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42678/
-----------------------------------------------------------
(Updated Jan. 23, 2016, 9:16 a.m.)
Review request for mesos.
Changes
-------
Add description
Summary (updated)
-----------------
WIP: Avoid `slave.total` do not contain `slave.allocated` in allocator.
Bugs: MESOS-4442
https://issues.apache.org/jira/browse/MESOS-4442
Repository: mesos
Description (updated)
-------
__Phenomenon__:
In master log, `slave.allocated` may have more resources than `slave.total`.
__Root Cause__:
Not trace revocable resources in allocator; so the info maybe different between Master/Slave because of race condition.
__Solution/Fix__:
Trace revocable resources in allocator.
Diffs
-----
src/tests/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf
Diff: https://reviews.apache.org/r/42678/diff/
Testing (updated)
-------
make check GTEST_FILTER="OversubscriptionTest.OverOffered"
Thanks,
Klaus Ma