You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/12 14:39:04 UTC
[GitHub] [incubator-nuttx] HidenoriMatsubayashi opened a new pull request, #7295: arch/arm64: cleanup configs independent of CPU core types
HidenoriMatsubayashi opened a new pull request, #7295:
URL: https://github.com/apache/incubator-nuttx/pull/7295
## Summary
`Use CONFIG_ARCH_CHIP_QEMU` instead of `CONFIG_ARCH_CHIP_QEMU_A53`. This is because these configurations depend on the hardware configuration of qemu (memory map, irq numbers, etc.). They independent of CPU core types.
Memory map for qemu virtio:
https://github.com/qemu/qemu/blob/master/hw/arm/virt.c
## Impact
None
## Testing
Confirmed that OS booted on qemu for both cortex-a53 and cortex-a72.
```shell
qemu-system-aarch64 -cpu cortex-a53 -smp 4 -nographic -machine virt,virtualization=on,gic-version=3 -net none -chardev stdio,id=con,mux=on -serial chardev:con -mon chardev=con,mode=readline -kernel ./nuttx
```
```shell
qemu-system-aarch64 -cpu cortex-a72 -smp 4 -nographic -machine virt,virtualization=on,gic-version=3 -net none -chardev stdio,id=con,mux=on -serial chardev:con -mon chardev=con,mode=readline -kernel ./nuttx
```
Signed-off-by: Hidenori Matsubayashi <hi...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7295: arch/arm64: cleanup configs independent of CPU core types
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7295:
URL: https://github.com/apache/incubator-nuttx/pull/7295#issuecomment-1276526338
> Or, perhaps we should create a new config for qemu virt? (e.g. `CONFIG_ARCH_CHIP_QEMU_VIRT`).
it's more simple to remove _A53 suffix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] HidenoriMatsubayashi commented on pull request #7295: arch/arm64: cleanup defconfigs
Posted by GitBox <gi...@apache.org>.
HidenoriMatsubayashi commented on PR #7295:
URL: https://github.com/apache/incubator-nuttx/pull/7295#issuecomment-1277507186
Thanks for the reviews.
> I think we should also change the name CONFIG_ARCH_BOARD_QEMU_A53 (+ directory name).
I'll create a new patch and send it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] HidenoriMatsubayashi commented on a diff in pull request #7295: arch/arm64: cleanup defconfigs
Posted by GitBox <gi...@apache.org>.
HidenoriMatsubayashi commented on code in PR #7295:
URL: https://github.com/apache/incubator-nuttx/pull/7295#discussion_r994445371
##########
boards/arm64/qemu/qemu-a53/configs/nsh/defconfig:
##########
@@ -11,7 +11,6 @@ CONFIG_ARCH_BOARD="qemu-a53"
CONFIG_ARCH_BOARD_QEMU_A53=y
CONFIG_ARCH_CHIP="qemu"
CONFIG_ARCH_CHIP_QEMU=y
-CONFIG_ARCH_CHIP_QEMU_A53=y
Review Comment:
OK, I'll fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7295: arch/arm64: cleanup configs independent of CPU core types
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7295:
URL: https://github.com/apache/incubator-nuttx/pull/7295#issuecomment-1276528820
> > Or, perhaps we should create a new config for qemu virt? (e.g. `CONFIG_ARCH_CHIP_QEMU_VIRT`).
>
> it's more simple to remove _A53 suffix.
@HidenoriMatsubayashi could you remove all _A53, if the code work with other armv8a core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #7295: arch/arm64: cleanup configs independent of CPU core types
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #7295:
URL: https://github.com/apache/incubator-nuttx/pull/7295#issuecomment-1276821787
>let's ignore the temp ci broken and merge this simple change directly.
@xiaoxiang781216
Do you know why the CI breaks now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] HidenoriMatsubayashi commented on pull request #7295: arch/arm64: cleanup configs independent of CPU core types
Posted by GitBox <gi...@apache.org>.
HidenoriMatsubayashi commented on PR #7295:
URL: https://github.com/apache/incubator-nuttx/pull/7295#issuecomment-1276304245
Or, perhaps we should create a new config for qemu virt (e.g. CONFIG_ARCH_CHIP_QEMU_VIRT).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] HidenoriMatsubayashi commented on pull request #7295: arch/arm64: cleanup configs independent of CPU core types
Posted by GitBox <gi...@apache.org>.
HidenoriMatsubayashi commented on PR #7295:
URL: https://github.com/apache/incubator-nuttx/pull/7295#issuecomment-1276808629
> could you remove all _A53, if the code work with other armv8a core.
Ok, I'll do try that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] HidenoriMatsubayashi commented on pull request #7295: arch/arm64: cleanup configs independent of CPU core types
Posted by GitBox <gi...@apache.org>.
HidenoriMatsubayashi commented on PR #7295:
URL: https://github.com/apache/incubator-nuttx/pull/7295#issuecomment-1276296855
Hi @MasayukiIshikawa @xiaoxiang781216
Can you please review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7295: arch/arm64: cleanup defconfigs
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7295:
URL: https://github.com/apache/incubator-nuttx/pull/7295#discussion_r994442729
##########
boards/arm64/qemu/qemu-a53/configs/nsh/defconfig:
##########
@@ -11,7 +11,6 @@ CONFIG_ARCH_BOARD="qemu-a53"
CONFIG_ARCH_BOARD_QEMU_A53=y
CONFIG_ARCH_CHIP="qemu"
CONFIG_ARCH_CHIP_QEMU=y
-CONFIG_ARCH_CHIP_QEMU_A53=y
Review Comment:
I think we can fix in one patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7295: arch/arm64: cleanup configs independent of CPU core types
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7295:
URL: https://github.com/apache/incubator-nuttx/pull/7295#issuecomment-1276526891
let's ignore the temp ci broken and merge this simple change directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #7295: arch/arm64: cleanup configs independent of CPU core types
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #7295:
URL: https://github.com/apache/incubator-nuttx/pull/7295#issuecomment-1276815494
@HidenoriMatsubayashi
Please use @masayuki2009 the next time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7295: arch/arm64: cleanup defconfigs
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7295:
URL: https://github.com/apache/incubator-nuttx/pull/7295#discussion_r994404885
##########
boards/arm64/qemu/qemu-a53/configs/nsh/defconfig:
##########
@@ -11,7 +11,6 @@ CONFIG_ARCH_BOARD="qemu-a53"
CONFIG_ARCH_BOARD_QEMU_A53=y
CONFIG_ARCH_CHIP="qemu"
CONFIG_ARCH_CHIP_QEMU=y
-CONFIG_ARCH_CHIP_QEMU_A53=y
Review Comment:
@HidenoriMatsubayashi need change Kconfig too, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7295: arch/arm64: cleanup defconfigs
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7295:
URL: https://github.com/apache/incubator-nuttx/pull/7295#issuecomment-1277456023
Let's ignore the ci temp break.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7295: arch/arm64: cleanup defconfigs
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7295:
URL: https://github.com/apache/incubator-nuttx/pull/7295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #7295: arch/arm64: cleanup configs independent of CPU core types
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #7295:
URL: https://github.com/apache/incubator-nuttx/pull/7295#issuecomment-1276850452
>Do you know why the CI breaks now?
I've just merged the following PR.
https://github.com/apache/incubator-nuttx/pull/7294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] HidenoriMatsubayashi commented on a diff in pull request #7295: arch/arm64: cleanup defconfigs
Posted by GitBox <gi...@apache.org>.
HidenoriMatsubayashi commented on code in PR #7295:
URL: https://github.com/apache/incubator-nuttx/pull/7295#discussion_r994418555
##########
boards/arm64/qemu/qemu-a53/configs/nsh/defconfig:
##########
@@ -11,7 +11,6 @@ CONFIG_ARCH_BOARD="qemu-a53"
CONFIG_ARCH_BOARD_QEMU_A53=y
CONFIG_ARCH_CHIP="qemu"
CONFIG_ARCH_CHIP_QEMU=y
-CONFIG_ARCH_CHIP_QEMU_A53=y
Review Comment:
By the way, I think we should also change the name `CONFIG_ARCH_BOARD_QEMU_A53` (+ directory name). Shall I respond with another PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] HidenoriMatsubayashi commented on a diff in pull request #7295: arch/arm64: cleanup defconfigs
Posted by GitBox <gi...@apache.org>.
HidenoriMatsubayashi commented on code in PR #7295:
URL: https://github.com/apache/incubator-nuttx/pull/7295#discussion_r994413328
##########
boards/arm64/qemu/qemu-a53/configs/nsh/defconfig:
##########
@@ -11,7 +11,6 @@ CONFIG_ARCH_BOARD="qemu-a53"
CONFIG_ARCH_BOARD_QEMU_A53=y
CONFIG_ARCH_CHIP="qemu"
CONFIG_ARCH_CHIP_QEMU=y
-CONFIG_ARCH_CHIP_QEMU_A53=y
Review Comment:
Thanks. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org