You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/01 02:28:37 UTC
[GitHub] [apisix-helm-chart] anjia0532 opened a new pull request #107: chore: bump apisix to 2.7-alpine
anjia0532 opened a new pull request #107:
URL: https://github.com/apache/apisix-helm-chart/pull/107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] anjia0532 commented on pull request #107: chore: bump apisix to 2.7-alpine
Posted by GitBox <gi...@apache.org>.
anjia0532 commented on pull request #107:
URL: https://github.com/apache/apisix-helm-chart/pull/107#issuecomment-874564139
@tao12345666333 Please take a review again, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] anjia0532 commented on pull request #107: chore: bump apisix to 2.7-alpine
Posted by GitBox <gi...@apache.org>.
anjia0532 commented on pull request #107:
URL: https://github.com/apache/apisix-helm-chart/pull/107#issuecomment-874606136
@tao12345666333 😅 Sorry,Please take a review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #107: chore: bump apisix to 2.7-alpine
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #107:
URL: https://github.com/apache/apisix-helm-chart/pull/107#issuecomment-875277421
```
➜ ingress-nginx git:(master) ✗ helm repo update
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "apisix" chart repository
...Successfully got an update from the "ingress-nginx" chart repository
...Successfully got an update from the "rancher-latest" chart repository
...Successfully got an update from the "bitnami" chart repository
Update Complete. ⎈Happy Helming!⎈
➜ ingress-nginx git:(master) ✗ helm search repo apisix
NAME CHART VERSION APP VERSION DESCRIPTION
apisix/apisix 0.3.5 2.7.0 A Helm chart for Apache APISIX
apisix/apisix-dashboard 0.1.5 2.7.0 A Helm chart for Apache APISIX Dashboard
apisix/apisix-ingress-controller 0.5.0 1.0.0 Apache APISIX Ingress Controller for Kubernetes
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #107: chore: bump apisix to 2.7-alpine
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #107:
URL: https://github.com/apache/apisix-helm-chart/pull/107#discussion_r662123907
##########
File path: charts/apisix/Chart.yaml
##########
@@ -31,20 +31,20 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.3.4
+version: 0.3.5
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
-appVersion: 2.6.0
+appVersion: 2.7.0
dependencies:
- name: etcd
version: 6.2.6
repository: https://charts.bitnami.com/bitnami
condition: etcd.enabled
- name: apisix-dashboard
- version: 0.1.4
+ version: 0.1.5
Review comment:
The apisix-dashboard chart `0.1.5` hasn't released yet. This change will break the helm dependencies installation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #107: chore: bump apisix to 2.7-alpine
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #107:
URL: https://github.com/apache/apisix-helm-chart/pull/107#issuecomment-874590200
Do you forget to submit the `charts/apisix/Chart.yaml` file? The `dependencies.apisix-dashboard` should update to 0.1.5
```diff
diff --git a/charts/apisix/Chart.yaml b/charts/apisix/Chart.yaml
index 21edd21..77a1047 100644
--- a/charts/apisix/Chart.yaml
+++ b/charts/apisix/Chart.yaml
@@ -44,7 +44,7 @@ dependencies:
repository: https://charts.bitnami.com/bitnami
condition: etcd.enabled
- name: apisix-dashboard
- version: 0.1.4
+ version: 0.1.5
repository: https://charts.apiseven.com
condition: dashboard.enabled
alias: dashboard
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] anjia0532 closed pull request #107: chore: bump apisix to 2.7-alpine
Posted by GitBox <gi...@apache.org>.
anjia0532 closed pull request #107:
URL: https://github.com/apache/apisix-helm-chart/pull/107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] anjia0532 edited a comment on pull request #107: chore: bump apisix to 2.7-alpine
Posted by GitBox <gi...@apache.org>.
anjia0532 edited a comment on pull request #107:
URL: https://github.com/apache/apisix-helm-chart/pull/107#issuecomment-874413447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] anjia0532 commented on pull request #107: chore: bump apisix to 2.7-alpine
Posted by GitBox <gi...@apache.org>.
anjia0532 commented on pull request #107:
URL: https://github.com/apache/apisix-helm-chart/pull/107#issuecomment-874516988
@tao12345666333 Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on pull request #107: chore: bump apisix to 2.7-alpine
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #107:
URL: https://github.com/apache/apisix-helm-chart/pull/107#issuecomment-871872211
@anjia0532 Please also change the app version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] anjia0532 commented on pull request #107: chore: bump apisix to 2.7-alpine
Posted by GitBox <gi...@apache.org>.
anjia0532 commented on pull request #107:
URL: https://github.com/apache/apisix-helm-chart/pull/107#issuecomment-874413447
@tao12345666333
```
sudo helm dependency update -n apisix --kubeconfig /etc/rancher/k3s/k3s.yaml
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "rancher-stable" chart repository
...Successfully got an update from the "apisix" chart repository
...Successfully got an update from the "jetstack" chart repository
...Successfully got an update from the "bitnami" chart repository
Update Complete. ⎈Happy Helming!⎈
Error: can't get a valid version for repositories apisix-dashboard. Try changing the version constraint in Chart.yaml
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #107: chore: bump apisix to 2.7-alpine
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #107:
URL: https://github.com/apache/apisix-helm-chart/pull/107#issuecomment-874528924
And you need run ` helm dependency update charts/apisix` in current repo root dir. You will get some outputs like below.
```
➜ apisix-helm-chart git:(master) ✗ helm dependency update charts/apisix
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "apisix" chart repository
...Successfully got an update from the "ingress-nginx" chart repository
...Successfully got an update from the "bitnami" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 3 charts
Downloading etcd from repo https://charts.bitnami.com/bitnami
Downloading apisix-dashboard from repo https://charts.apiseven.com
Downloading apisix-ingress-controller from repo https://charts.apiseven.com
Deleting outdated charts
➜ apisix-helm-chart git:(master) ✗ gst
On branch master
Your branch is up to date with 'origin/master'.
Changes not staged for commit:
(use "git add/rm <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: charts/apisix/Chart.lock
modified: charts/apisix/Chart.yaml
deleted: charts/apisix/charts/apisix-dashboard-0.1.4.tgz
modified: charts/apisix/charts/apisix-ingress-controller-0.5.0.tgz
Untracked files:
(use "git add <file>..." to include in what will be committed)
charts/apisix/charts/apisix-dashboard-0.1.5.tgz
no changes added to commit (use "git add" and/or "git commit -a")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 edited a comment on pull request #107: chore: bump apisix to 2.7-alpine
Posted by GitBox <gi...@apache.org>.
tao12345666333 edited a comment on pull request #107:
URL: https://github.com/apache/apisix-helm-chart/pull/107#issuecomment-874590200
Do you forget to submit the `charts/apisix/Chart.yaml` file and `charts/apisix/Chart.lock`? The `dependencies.apisix-dashboard` should update to 0.1.5
```diff
diff --git a/charts/apisix/Chart.yaml b/charts/apisix/Chart.yaml
index 21edd21..77a1047 100644
--- a/charts/apisix/Chart.yaml
+++ b/charts/apisix/Chart.yaml
@@ -44,7 +44,7 @@ dependencies:
repository: https://charts.bitnami.com/bitnami
condition: etcd.enabled
- name: apisix-dashboard
- version: 0.1.4
+ version: 0.1.5
repository: https://charts.apiseven.com
condition: dashboard.enabled
alias: dashboard
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] anjia0532 commented on pull request #107: chore: bump apisix to 2.7-alpine
Posted by GitBox <gi...@apache.org>.
anjia0532 commented on pull request #107:
URL: https://github.com/apache/apisix-helm-chart/pull/107#issuecomment-871876792
@tokers done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] anjia0532 edited a comment on pull request #107: chore: bump apisix to 2.7-alpine
Posted by GitBox <gi...@apache.org>.
anjia0532 edited a comment on pull request #107:
URL: https://github.com/apache/apisix-helm-chart/pull/107#issuecomment-874413447
@tao12345666333
```
sudo helm dependency update -n apisix --kubeconfig /etc/rancher/k3s/k3s.yaml
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "rancher-stable" chart repository
...Successfully got an update from the "apisix" chart repository
...Successfully got an update from the "jetstack" chart repository
...Successfully got an update from the "bitnami" chart repository
Update Complete. ⎈Happy Helming!⎈
Error: can't get a valid version for repositories apisix-dashboard. Try changing the version constraint in Chart.yaml
```
是不是 #108 合并到master，但是没合并到 https://charts.apiseven.com ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] anjia0532 edited a comment on pull request #107: chore: bump apisix to 2.7-alpine
Posted by GitBox <gi...@apache.org>.
anjia0532 edited a comment on pull request #107:
URL: https://github.com/apache/apisix-helm-chart/pull/107#issuecomment-874422480
> You should run helm dependence update to update all dependence charts.
reduce apisix-dashboard version to 0.1.4 ,it's ok
```
sudo helm dependency update -n apisix --kubeconfig /etc/rancher/k3s/k3s.yaml
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "rancher-stable" chart repository
...Successfully got an update from the "apisix" chart repository
...Successfully got an update from the "jetstack" chart repository
...Successfully got an update from the "bitnami" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 3 charts
Downloading etcd from repo https://charts.bitnami.com/bitnami
Downloading apisix-dashboard from repo https://charts.apiseven.com
Downloading apisix-ingress-controller from repo https://charts.apiseven.com
Deleting outdated charts
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #107: chore: bump apisix to 2.7-alpine
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #107:
URL: https://github.com/apache/apisix-helm-chart/pull/107#issuecomment-874514073
> 是不是 #108 合并到master，但是没合并到 https://charts.apiseven.com ?
yep. I have deployed it. Please update apisix-dashboard chart to v0.1.5. thanks!
```
➜ ~ helm search repo apisix
NAME CHART VERSION APP VERSION DESCRIPTION
apisix/apisix 0.3.4 2.6.0 A Helm chart for Apache APISIX
apisix/apisix-dashboard 0.1.5 2.7.0 A Helm chart for Apache APISIX Dashboard
apisix/apisix-ingress-controller 0.5.0 1.0.0 Apache APISIX Ingress Controller for Kubernetes
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] anjia0532 commented on pull request #107: chore: bump apisix to 2.7-alpine
Posted by GitBox <gi...@apache.org>.
anjia0532 commented on pull request #107:
URL: https://github.com/apache/apisix-helm-chart/pull/107#issuecomment-874413447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #107: chore: bump apisix to 2.7-alpine
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #107:
URL: https://github.com/apache/apisix-helm-chart/pull/107#issuecomment-874074862
You should run helm dependence update to update all dependence charts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers merged pull request #107: chore: bump apisix to 2.7-alpine
Posted by GitBox <gi...@apache.org>.
tokers merged pull request #107:
URL: https://github.com/apache/apisix-helm-chart/pull/107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on pull request #107: chore: bump apisix to 2.7-alpine
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #107:
URL: https://github.com/apache/apisix-helm-chart/pull/107#issuecomment-872076819
We should need to wait until #108 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 edited a comment on pull request #107: chore: bump apisix to 2.7-alpine
Posted by GitBox <gi...@apache.org>.
tao12345666333 edited a comment on pull request #107:
URL: https://github.com/apache/apisix-helm-chart/pull/107#issuecomment-874590200
Do you forget to submit the `charts/apisix/Chart.yaml` file and `charts/apisix/Chart.lock`? The `dependencies.apisix-dashboard` should update to 0.1.5
```diff
diff --git a/charts/apisix/Chart.yaml b/charts/apisix/Chart.yaml
index 21edd21..77a1047 100644
--- a/charts/apisix/Chart.yaml
+++ b/charts/apisix/Chart.yaml
@@ -44,7 +44,7 @@ dependencies:
repository: https://charts.bitnami.com/bitnami
condition: etcd.enabled
- name: apisix-dashboard
- version: 0.1.4
+ version: 0.1.5
repository: https://charts.apiseven.com
condition: dashboard.enabled
alias: dashboard
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] anjia0532 commented on pull request #107: chore: bump apisix to 2.7-alpine
Posted by GitBox <gi...@apache.org>.
anjia0532 commented on pull request #107:
URL: https://github.com/apache/apisix-helm-chart/pull/107#issuecomment-874422480
> You should run helm dependence update to update all dependence charts.
reduce apisix-dashboard version to 0.1.4
```
sudo helm dependency update -n apisix --kubeconfig /etc/rancher/k3s/k3s.yaml
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "rancher-stable" chart repository
...Successfully got an update from the "apisix" chart repository
...Successfully got an update from the "jetstack" chart repository
...Successfully got an update from the "bitnami" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 3 charts
Downloading etcd from repo https://charts.bitnami.com/bitnami
Downloading apisix-dashboard from repo https://charts.apiseven.com
Downloading apisix-ingress-controller from repo https://charts.apiseven.com
Deleting outdated charts
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #107: chore: bump apisix to 2.7-alpine
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #107:
URL: https://github.com/apache/apisix-helm-chart/pull/107#issuecomment-874074862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] anjia0532 edited a comment on pull request #107: chore: bump apisix to 2.7-alpine
Posted by GitBox <gi...@apache.org>.
anjia0532 edited a comment on pull request #107:
URL: https://github.com/apache/apisix-helm-chart/pull/107#issuecomment-874413447
@tao12345666333
```
sudo helm dependency update -n apisix --kubeconfig /etc/rancher/k3s/k3s.yaml
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "rancher-stable" chart repository
...Successfully got an update from the "apisix" chart repository
...Successfully got an update from the "jetstack" chart repository
...Successfully got an update from the "bitnami" chart repository
Update Complete. ⎈Happy Helming!⎈
Error: can't get a valid version for repositories apisix-dashboard. Try changing the version constraint in Chart.yaml
```
是不是 #108 合并到master，但是没合并到 https://charts.apiseven.com ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org