You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/10 03:44:01 UTC
[GitHub] zhijiangW commented on a change in pull request #6809:
[FLINK-10491][network] Pass BufferPoolOwner in the constructor of
LocalBufferPool
zhijiangW commented on a change in pull request #6809: [FLINK-10491][network] Pass BufferPoolOwner in the constructor of LocalBufferPool
URL: https://github.com/apache/flink/pull/6809#discussion_r223929018
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java
##########
@@ -349,11 +346,13 @@ public void setNumBuffers(int numBuffers) throws IOException {
returnExcessMemorySegments();
- // If there is a registered owner and we have still requested more buffers than our
- // size, trigger a recycle via the owner.
- if (owner != null && numberOfRequestedMemorySegments > currentPoolSize) {
- owner.releaseMemory(numberOfRequestedMemorySegments - currentPoolSize);
- }
+ numReleased = numberOfRequestedMemorySegments - currentPoolSize;
Review comment:
Yes, I will adjust this variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services